[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Changes to kcron
From:       Adriaan de Groot <adridg () cs ! kun ! nl>
Date:       2004-01-30 23:34:47
Message-ID: 200401310034.51673.adridg () cs ! kun ! nl
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 30 January 2004 23:16, James Ots wrote:
> Well, I started off with a little patch and got a bit carried away.

A good thing. I've committed to HEAD - we'll need to sort out the backport.

> I think there are a lot of nicer ways of doing the coding for the interface
> from how it's currently done, but this is the first time I've touched KDE
> GUI code, so I thought I'd better not try to do anything too fancy.

OK. CHalk that up for your next activity - KStandardActions.

> Yes, that was my response to that too. I considered changing it, but
> stopped before I ended up rewriting the whole app!

My previous commit message was to the effect of "this app needs a serious 
going-over to remove all the string cruftiness and be QString-only". 

> I've noticed one more change that needs to be made - in ktvariable.h the
> #include <qmultilineedit.h> needs to be replaced with #include
> <qtextedit.h>.

A moment of reflection on style: in header files X where you only use pointers 
and references to a particular class, it is faster to declare that class as a 
class (i.e. write "class foo;" in the header file) and then #include the 
requisite header file in the C++ source file. That saves including the header 
file when it is not needed during #inclusion of the header file X. It's a 
small thing.

Well anyway, that's how I'd do it,  so that's how I'm committing it - if CVS 
ever wakes up again.

- -- 
pub  1024D/FEA2A3FE 2002-06-18 Adriaan de Groot <groot@kde.org>
            If the door is ajar, can we fill it with door-jamb?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQFAGuobdqzuAf6io/4RAqwVAKCIJTIgQ40IEV+m+JCdD/qDb+dCNwCgoMwV
6StSFvBjympjMi6PvN6FoeQ=
=KylT
-----END PGP SIGNATURE-----
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]