[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens
From: "Nick Shaforostoff" <shafff () ukr ! net>
Date: 2015-02-04 0:31:09
Message-ID: 20150204003109.19248.92929 () probe ! kde ! org
[Download RAW message or body]
--===============6061816668009550530==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122320/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 12:31 a.m.)
Review request for kde-workspace, Martin Gräßlin and Thomas Lübking.
Changes
-------
-fix target_link_libraries in CMakeLists.txt
-use XCB_FOUND check instead of X11
this introduces new file config-xcb.h.cmake with the following contents:
/* Define if you have XCB at all */
#cmakedefine XCB_FOUND
Repository: plasma-workspace
Description
-------
this patch makes kcminit behave like in kde4: it uses proper xcb screen count which \
may be different from QGuiApplication::screens().count().
for example when i connext external monitor via vga to my laptop, xcb screen count is \
still '1', while QGuiApplication::screens().count() returns '2'.
switching from QGuiApplication to QCoreApplication still wasn't possible because \
modules like 'mouse' need gui initialized and would crash if kcminit uses \
QCoreApplication.
Diffs (updated)
-----
startkde/kcminit/CMakeLists.txt b17951f
startkde/kcminit/main.cpp 1008966
Diff: https://git.reviewboard.kde.org/r/122320/diff/
Testing
-------
i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries in \
the system and successfuly could run kcminit_startup and reboot also went fine.
Thanks,
Nick Shaforostoff
--===============6061816668009550530==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122320/">https://git.reviewboard.kde.org/r/122320/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kde-workspace, Martin Gräßlin and Thomas Lübking.</div>
<div>By Nick Shaforostoff.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2015, 12:31 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">-fix target_link_libraries in CMakeLists.txt
-use XCB_FOUND check instead of X11
this introduces new file config-xcb.h.cmake with the following contents:
/* Define if you have XCB at all */
#cmakedefine XCB_FOUND
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this patch makes kcminit behave like in kde4: it uses \
proper xcb screen count which may be different from \
QGuiApplication::screens().count().</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">for example when i \
connext external monitor via vga to my laptop, xcb screen count is still '1', while \
QGuiApplication::screens().count() returns '2'.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">switching from QGuiApplication to QCoreApplication still wasn't possible \
because modules like 'mouse' need gui initialized and would crash if kcminit uses \
QCoreApplication.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">i have built kcminit on ubuntu vivid alpha 32-bit, \
replaced binaries and libraries in the system and successfuly could run \
kcminit_startup and reboot also went fine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>startkde/kcminit/CMakeLists.txt <span style="color: grey">(b17951f)</span></li>
<li>startkde/kcminit/main.cpp <span style="color: grey">(1008966)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122320/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6061816668009550530==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic