'Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2015-02-04 9:16:22
Message-ID: 20150204091622.19249.10044 () probe ! kde ! org
[Download RAW message or body]

--===============7068322373887738685==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122320/#review75358
-----------------------------------------------------------



startkde/kcminit/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122320/#comment52123>

    you forgot to git add the config-xcb.h.cmake


- Martin Gräßlin


On Feb. 4, 2015, 1:31 a.m., Nick Shaforostoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122320/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 1:31 a.m.)
> 
> 
> Review request for kde-workspace, Martin Gräßlin and Thomas Lübking.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> this patch makes kcminit behave like in kde4: it uses proper xcb screen count which \
> may be different from QGuiApplication::screens().count(). 
> for example when i connext external monitor via vga to my laptop, xcb screen count \
> is still '1', while QGuiApplication::screens().count() returns '2'. 
> switching from QGuiApplication to QCoreApplication still wasn't possible because \
> modules like 'mouse' need gui initialized and would crash if kcminit uses \
> QCoreApplication. 
> 
> Diffs
> -----
> 
> startkde/kcminit/CMakeLists.txt b17951f 
> startkde/kcminit/main.cpp 1008966 
> 
> Diff: https://git.reviewboard.kde.org/r/122320/diff/
> 
> 
> Testing
> -------
> 
> i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries \
> in the system and successfuly could run kcminit_startup and reboot also went fine. 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
> 


--===============7068322373887738685==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122320/">https://git.reviewboard.kde.org/r/122320/</a>
  </td>
    </tr>
   </table>
   <br />











<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/122320/diff/4/?file=346734#file346734line6" \
style="color: black; font-weight: bold; text-decoration: \
underline;">startkde/kcminit/CMakeLists.txt</a>  <span style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">6</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">configure_file</span><span class="p">(</span><span \
class="s">config-xcb.h.cmake</span> <span class="o">${</span><span \
class="nv">CMAKE_CURRENT_BINARY_DIR</span><span class="o">}</span><span \
class="s">/config-xcb.h</span><span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you \
forgot to git add the config-xcb.h.cmake</p></pre>  </div>
</div>
<br />



<p>- Martin Gräßlin</p>


<br />
<p>On February 4th, 2015, 1:31 a.m. CET, Nick Shaforostoff wrote:</p>









<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kde-workspace, Martin Gräßlin and Thomas Lübking.</div>
<div>By Nick Shaforostoff.</div>


<p style="color: grey;"><i>Updated Feb. 4, 2015, 1:31 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this patch makes kcminit behave like in kde4: it uses \
proper xcb screen count which may be different from \
QGuiApplication::screens().count().</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">for example when i \
connext external monitor via vga to my laptop, xcb screen count is still '1', while \
QGuiApplication::screens().count() returns '2'.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">switching from QGuiApplication to QCoreApplication still wasn't possible \
because modules like 'mouse' need gui initialized and would crash if kcminit uses \
QCoreApplication.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">i have built kcminit on ubuntu vivid alpha 32-bit, \
replaced binaries and libraries in the system and successfuly could run \
kcminit_startup and reboot also went fine.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>startkde/kcminit/CMakeLists.txt <span style="color: grey">(b17951f)</span></li>

 <li>startkde/kcminit/main.cpp <span style="color: grey">(1008966)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122320/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============7068322373887738685==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic