[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens
From: "Nick Shaforostoff" <shafff () ukr ! net>
Date: 2015-02-03 13:48:25
Message-ID: 20150203134825.19248.36870 () probe ! kde ! org
[Download RAW message or body]
--===============1952162928672274853==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Лют. 3, 2015, 7:08 до полудня, Martin Gräßlin wrote:
> > startkde/kcminit/CMakeLists.txt, line 16
> > <https://git.reviewboard.kde.org/r/122320/diff/3/?file=346481#file346481line16>
> >
> > you find optional, but link required. OSX devs won't be happy with that change \
> > ;-)
> > you need to do something like:
> > if (XCB_XCB_FOUND)
> > target_link_libraries(kdeinit_kcminit XCB::XCB)
> > endif()
>
> Nick Shaforostoff wrote:
> it compiles even if i remove find_package(XCB) -- XCB::XCB variable is just empty \
> then
update: probably this is because XCB is already found by some upper CMakeLists.txt.
i will adjust the code this evening
- Nick
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122320/#review75256
-----------------------------------------------------------
On Лют. 2, 2015, 9:15 після полудня, Nick Shaforostoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122320/
> -----------------------------------------------------------
>
> (Updated Лют. 2, 2015, 9:15 після полудня)
>
>
> Review request for kde-workspace, Martin Gräßlin and Thomas Lübking.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> this patch makes kcminit behave like in kde4: it uses proper xcb screen count which \
> may be different from QGuiApplication::screens().count().
> for example when i connext external monitor via vga to my laptop, xcb screen count \
> is still '1', while QGuiApplication::screens().count() returns '2'.
> switching from QGuiApplication to QCoreApplication still wasn't possible because \
> modules like 'mouse' need gui initialized and would crash if kcminit uses \
> QCoreApplication.
>
> Diffs
> -----
>
> components/CMakeLists.txt 42c820f
> startkde/kcminit/CMakeLists.txt b17951f
> startkde/kcminit/main.cpp 1008966
>
> Diff: https://git.reviewboard.kde.org/r/122320/diff/
>
>
> Testing
> -------
>
> i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries \
> in the system and successfuly could run kcminit_startup and reboot also went fine.
>
> Thanks,
>
> Nick Shaforostoff
>
>
--===============1952162928672274853==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122320/">https://git.reviewboard.kde.org/r/122320/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Лютий 3rd, 2015, 7:08 до полудня \
UTC, <b>Martin Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122320/diff/3/?file=346481#file346481line16" \
style="color: black; font-weight: bold; text-decoration: \
underline;">startkde/kcminit/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">10</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c">#Qt5::Gui is \
for multihead disabling, remove it if KDE_MULTIHEAD will always be \
true</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; \
border-right: 1px solid #C0C0C0;" align="right"><font size="2">16</font></th> <td \
bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span \
class="s">kdeinit_kcminit</span> <span class="s">Qt5::Core</span> <span \
class="s">Qt5::Gui</span> <span class="s">Qt5::DBus</span> <span \
class="s">KF5::CoreAddons</span> <span class="s">KF5::Service</span> <span \
class="s">KF5::I18n</span> <span class="s">XCB::XCB</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you \
find optional, but link required. OSX devs won't be happy with that change ;-)</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">you need to do something like: if (XCB_XCB_FOUND)
target_link_libraries(kdeinit_kcminit XCB::XCB)
endif()</p></pre>
</blockquote>
<p>On Лютий 3rd, 2015, 1:34 після полудня UTC, <b>Nick \
Shaforostoff</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">it compiles even if i remove find_package(XCB) -- \
XCB::XCB variable is just empty then</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">update: probably this is because XCB is already found by some upper \
CMakeLists.txt. i will adjust the code this evening</p></pre>
<br />
<p>- Nick</p>
<br />
<p>On Лютий 2nd, 2015, 9:15 після полудня UTC, Nick Shaforostoff \
wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kde-workspace, Martin Gräßlin and Thomas Lübking.</div>
<div>By Nick Shaforostoff.</div>
<p style="color: grey;"><i>Updated Лют. 2, 2015, 9:15 після \
полудня</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this patch makes kcminit behave like in kde4: it uses \
proper xcb screen count which may be different from \
QGuiApplication::screens().count().</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">for example when i \
connext external monitor via vga to my laptop, xcb screen count is still '1', while \
QGuiApplication::screens().count() returns '2'.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">switching from QGuiApplication to QCoreApplication still wasn't possible \
because modules like 'mouse' need gui initialized and would crash if kcminit uses \
QCoreApplication.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">i have built kcminit on ubuntu vivid alpha 32-bit, \
replaced binaries and libraries in the system and successfuly could run \
kcminit_startup and reboot also went fine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>components/CMakeLists.txt <span style="color: grey">(42c820f)</span></li>
<li>startkde/kcminit/CMakeLists.txt <span style="color: grey">(b17951f)</span></li>
<li>startkde/kcminit/main.cpp <span style="color: grey">(1008966)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122320/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1952162928672274853==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic