From kde-core-devel Wed Feb 04 00:31:09 2015 From: "Nick Shaforostoff" Date: Wed, 04 Feb 2015 00:31:09 +0000 To: kde-core-devel Subject: Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens Message-Id: <20150204003109.19248.92929 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=142300989321729 --===============6061816668009550530== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/ ----------------------------------------------------------- (Updated Feb. 4, 2015, 12:31 a.m.) Review request for kde-workspace, Martin Gräßlin and Thomas Lübking. Changes ------- -fix target_link_libraries in CMakeLists.txt -use XCB_FOUND check instead of X11 this introduces new file config-xcb.h.cmake with the following contents: /* Define if you have XCB at all */ #cmakedefine XCB_FOUND Repository: plasma-workspace Description ------- this patch makes kcminit behave like in kde4: it uses proper xcb screen count which may be different from QGuiApplication::screens().count(). for example when i connext external monitor via vga to my laptop, xcb screen count is still '1', while QGuiApplication::screens().count() returns '2'. switching from QGuiApplication to QCoreApplication still wasn't possible because modules like 'mouse' need gui initialized and would crash if kcminit uses QCoreApplication. Diffs (updated) ----- startkde/kcminit/CMakeLists.txt b17951f startkde/kcminit/main.cpp 1008966 Diff: https://git.reviewboard.kde.org/r/122320/diff/ Testing ------- i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries in the system and successfuly could run kcminit_startup and reboot also went fine. Thanks, Nick Shaforostoff --===============6061816668009550530== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/

Review request for kde-workspace, Martin Gräßlin and Thomas Lübking.
By Nick Shaforostoff.

Updated Feb. 4, 2015, 12:31 a.m.

Changes

-fix target_link_libraries in CMakeLists.txt
-use XCB_FOUND check instead of X11
this introduces new file config-xcb.h.cmake with the following contents:
/* Define if you have XCB at all */
#cmakedefine XCB_FOUND
Repository: plasma-workspace

Description 

this patch makes kcminit behave like in kde4: it uses proper xcb screen count which may be different from QGuiApplication::screens().count().


for example when i connext external monitor via vga to my laptop, xcb screen count is still '1', while QGuiApplication::screens().count() returns '2'.


switching from QGuiApplication to QCoreApplication still wasn't possible because modules like 'mouse' need gui initialized and would crash if kcminit uses QCoreApplication.

Testing 

i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries in the system and successfuly could run kcminit_startup and reboot also went fine.

Diffs (updated)

  • startkde/kcminit/CMakeLists.txt (b17951f)
  • startkde/kcminit/main.cpp (1008966)

View Diff
--===============6061816668009550530==--