[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113785: Fix Mozilla bookmark importing
From: "David Faure" <faure () kde ! org>
Date: 2013-11-10 15:51:27
Message-ID: 20131110155127.2658.32662 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113785/#review43352
-----------------------------------------------------------
Ship it!
kio/bookmarks/kbookmarkimporter_ns.cc
<http://git.reviewboard.kde.org/r/113785/#comment31228>
(could be more optimized with startsWith("<HR>", Qt::CaseInsensitive) -- but ok, \
the rest of the code uses toUpper, so this is ok for this commit)
- David Faure
On Nov. 10, 2013, 2:51 p.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113785/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2013, 2:51 p.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Bugs: 292495
> http://bugs.kde.org/show_bug.cgi?id=292495
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Currently the Mozilla bookmark importing code simply ignores any HTML tags preceded \
> by the <HR> element resulting in lines like
> <HR> <DT><H3 ADD_DATE="1364760832" LAST_MODIFIED="1364760921">magie</H3>
>
> simply being treated as a separator instead of a separator followed by a bookmark \
> entry. The attached patch addresses this problem.
>
> Diffs
> -----
>
> kio/bookmarks/kbookmarkimporter_ns.cc d3f0eaa
>
> Diff: http://git.reviewboard.kde.org/r/113785/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113785/">http://git.reviewboard.kde.org/r/113785/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113785/diff/1/?file=212403#file212403line65" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kio/bookmarks/kbookmarkimporter_ns.cc</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KNSBookmarkImporterImpl::parse()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">65</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">t</span><span \
class="p">.</span><span class="n">left</span><span class="p">(</span><span \
class="mi">4</span><span class="p">).</span><span class="n">toUpper</span><span \
class="p">()</span> <span class="o">==</span> <span \
class="s">"<HR>"</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(could be \
more optimized with startsWith("<HR>", Qt::CaseInsensitive) -- but \
ok, the rest of the code uses toUpper, so this is ok for this commit)</pre> </div>
<br />
<p>- David Faure</p>
<br />
<p>On November 10th, 2013, 2:51 p.m. UTC, Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2013, 2:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=292495">292495</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently the Mozilla bookmark importing code simply ignores any HTML \
tags preceded by the <HR> element resulting in lines like
<HR> <DT><H3 ADD_DATE="1364760832" \
LAST_MODIFIED="1364760921">magie</H3>
simply being treated as a separator instead of a separator followed by a bookmark \
entry. The attached patch addresses this problem.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/bookmarks/kbookmarkimporter_ns.cc <span style="color: \
grey">(d3f0eaa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113785/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic