From kde-core-devel Sun Nov 10 15:51:27 2013 From: "David Faure" Date: Sun, 10 Nov 2013 15:51:27 +0000 To: kde-core-devel Subject: Re: Review Request 113785: Fix Mozilla bookmark importing Message-Id: <20131110155127.2658.32662 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=138409872820373 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8538503994616878703==" --===============8538503994616878703== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113785/#review43352 ----------------------------------------------------------- Ship it! kio/bookmarks/kbookmarkimporter_ns.cc (could be more optimized with startsWith("
", Qt::CaseInsensitive) -- but ok, the rest of the code uses toUpper, so this is ok for this commit) - David Faure On Nov. 10, 2013, 2:51 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113785/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2013, 2:51 p.m.) > > > Review request for kdelibs and David Faure. > > > Bugs: 292495 > http://bugs.kde.org/show_bug.cgi?id=292495 > > > Repository: kdelibs > > > Description > ------- > > Currently the Mozilla bookmark importing code simply ignores any HTML tags preceded by the
element resulting in lines like > >

magie

> > simply being treated as a separator instead of a separator followed by a bookmark entry. The attached patch addresses this problem. > > > Diffs > ----- > > kio/bookmarks/kbookmarkimporter_ns.cc d3f0eaa > > Diff: http://git.reviewboard.kde.org/r/113785/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > > --===============8538503994616878703== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113785/

Ship it!

kio/bookmarks/kbookmarkimporter_ns.cc (Diff revision 1) 
void KNSBookmarkImporterImpl::parse()
 

    65
    
            if (t.left(4).toUpper() == "<HR>") {

  


 





(could be more optimized with startsWith("<HR>", Qt::CaseInsensitive) -- but ok, the rest of the code uses toUpper, so this is ok for this commit)









- David Faure






On November 10th, 2013, 2:51 p.m. UTC, Dawit Alemayehu wrote:











 

  


Review request for kdelibs and David Faure.


By Dawit Alemayehu.




Updated Nov. 10, 2013, 2:51 p.m.










 Bugs: 


 292495









 Repository: 
kdelibs





Description 

 

 

  
   
Currently the Mozilla bookmark importing code simply ignores any HTML tags preceded by the <HR> element resulting in lines like 

<HR>    <DT><H3 ADD_DATE="1364760832" LAST_MODIFIED="1364760921">magie</H3>

simply being treated as a separator instead of a separator followed by a bookmark entry. The attached patch addresses this problem.

  		
 







Diffs 


    

 
  • kio/bookmarks/kbookmarkimporter_ns.cc (d3f0eaa)
    • 





View Diff








  		
 











  

 



--===============8538503994616878703==--