This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113785/

Ship it!

kio/bookmarks/kbookmarkimporter_ns.cc (Diff revision 1) 
void KNSBookmarkImporterImpl::parse()
 

    65
    
            if (t.left(4).toUpper() == "<HR>") {

  


 





(could be more optimized with startsWith("<HR>", Qt::CaseInsensitive) -- but ok, the rest of the code uses toUpper, so this is ok for this commit)









- David Faure






On November 10th, 2013, 2:51 p.m. UTC, Dawit Alemayehu wrote:











 

  


Review request for kdelibs and David Faure.


By Dawit Alemayehu.




Updated Nov. 10, 2013, 2:51 p.m.










 Bugs: 


 292495









 Repository: 
kdelibs





Description 

 

 

  
   
Currently the Mozilla bookmark importing code simply ignores any HTML tags preceded by the <HR> element resulting in lines like 

<HR>    <DT><H3 ADD_DATE="1364760832" LAST_MODIFIED="1364760921">magie</H3>

simply being treated as a separator instead of a separator followed by a bookmark entry. The attached patch addresses this problem.

  		
 







Diffs 


    

 
  • kio/bookmarks/kbookmarkimporter_ns.cc (d3f0eaa)
    • 





View Diff