[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request 113785: Fix Mozilla bookmark importing
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2013-11-10 14:51:19
Message-ID: 20131110145119.19506.83184 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113785/
-----------------------------------------------------------
Review request for kdelibs and David Faure.
Bugs: 292495
http://bugs.kde.org/show_bug.cgi?id=292495
Repository: kdelibs
Description
-------
Currently the Mozilla bookmark importing code simply ignores any HTML tags preceded \
by the <HR> element resulting in lines like
<HR> <DT><H3 ADD_DATE="1364760832" LAST_MODIFIED="1364760921">magie</H3>
simply being treated as a separator instead of a separator followed by a bookmark \
entry. The attached patch addresses this problem.
Diffs
-----
kio/bookmarks/kbookmarkimporter_ns.cc d3f0eaa
Diff: http://git.reviewboard.kde.org/r/113785/diff/
Testing
-------
Thanks,
Dawit Alemayehu
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113785/">http://git.reviewboard.kde.org/r/113785/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=292495">292495</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently the Mozilla bookmark importing code simply ignores any HTML \
tags preceded by the <HR> element resulting in lines like
<HR> <DT><H3 ADD_DATE="1364760832" \
LAST_MODIFIED="1364760921">magie</H3>
simply being treated as a separator instead of a separator followed by a bookmark \
entry. The attached patch addresses this problem.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/bookmarks/kbookmarkimporter_ns.cc <span style="color: \
grey">(d3f0eaa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113785/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic