[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be
From:       Michael Pyne <mpyne () kde ! org>
Date:       2013-11-10 15:32:08
Message-ID: 4855578.TnusCD4bI9 () midna
[Download RAW message or body]


On Sun, November 10, 2013 11:18:19 Wolfgang Bauer wrote:
> > -----Original Message-----
> > From: Rolf Eike Beer [mailto:kde@opensource.sf-tec.de]
> > Sent: Sunday, November 10, 2013 9:11 AM
> > To: kde-core-devel@kde.org; Wolfgang Bauer
> > Cc: David Stephen Hubner
> > Subject: Re: Review Request 113779: KInfocenter/OpenGL: fix
> > ReadPipe() in the case that the command cannot be run
> > 
> > 
> > Can't this be ported to simply use QProcess instead?
> > 
> > Eike
> 
> Well, I only wanted to fix this bug... ;-)
> But I can have a look at reimplementing this with QProcess as well.
> 
> How should I proceed?
> Commit this for now to fix the bug (maybe to the 4.11 branch only)?
> Or discard this patch and just rewrite ReadPipe() using QProcess?

I would recommend applying the patch to 4.11 and master and then investigating 
whether QProcess would be suitable for master (this might also help with KF5 
and Windows porting, not that I expect KInfoCenter to do great things on 
Windows).

Regards,
 - Michael Pyne
["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]