From kde-core-devel Sun Nov 10 14:51:19 2013 From: "Dawit Alemayehu" Date: Sun, 10 Nov 2013 14:51:19 +0000 To: kde-core-devel Subject: Review Request 113785: Fix Mozilla bookmark importing Message-Id: <20131110145119.19506.83184 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=138409511419238 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0077105922861113438==" --===============0077105922861113438== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113785/ ----------------------------------------------------------- Review request for kdelibs and David Faure. Bugs: 292495 http://bugs.kde.org/show_bug.cgi?id=292495 Repository: kdelibs Description ------- Currently the Mozilla bookmark importing code simply ignores any HTML tags preceded by the
element resulting in lines like

magie

simply being treated as a separator instead of a separator followed by a bookmark entry. The attached patch addresses this problem. Diffs ----- kio/bookmarks/kbookmarkimporter_ns.cc d3f0eaa Diff: http://git.reviewboard.kde.org/r/113785/diff/ Testing ------- Thanks, Dawit Alemayehu --===============0077105922861113438== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113785/

Review request for kdelibs and David Faure.
By Dawit Alemayehu.
Bugs: 292495
Repository: kdelibs

Description 

Currently the Mozilla bookmark importing code simply ignores any HTML tags preceded by the <HR> element resulting in lines like 

<HR>    <DT><H3 ADD_DATE="1364760832" LAST_MODIFIED="1364760921">magie</H3>

simply being treated as a separator instead of a separator followed by a bookmark entry. The attached patch addresses this problem.

Diffs

  • kio/bookmarks/kbookmarkimporter_ns.cc (d3f0eaa)

View Diff
--===============0077105922861113438==--