[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113139: Try to export include targets for Plasma as well
From: "Stephen Kelly" <steveire () gmail ! com>
Date: 2013-10-07 11:50:34
Message-ID: 20131007115034.367.19362 () vidsolbach ! de
[Download RAW message or body]
> On Oct. 7, 2013, 9:35 a.m., Stephen Kelly wrote:
> > src/plasma/CMakeLists.txt, line 173
> > <http://git.reviewboard.kde.org/r/113139/diff/1/?file=199605#file199605line173>
> >
> > The if-else shouldn't be needed. INSTALL_INTERFACE should already check if \
> > ${INCLUDE_INSTALL_DIR} is absolute.
>
> Ben Cooksley wrote:
> I copied this code from KCoreAddons in kdelibs[frameworks]. Shall I correct it \
> there as well?
It appears in several other frameworks too. Actually your snippet is needed until \
CMake 2.8.12. I'll remove it from them all when kde requires that version.
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113139/#review41324
-----------------------------------------------------------
On Oct. 7, 2013, 10:48 a.m., Ben Cooksley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113139/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2013, 10:48 a.m.)
>
>
> Review request for kdelibs, Plasma and Stephen Kelly.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Add include targets for KF5::plasma, which will hopefully contribute towards fixing \
> the kde-workspace[master] build on build.kde.org. Unfortunately it isn't entirely \
> successful as it seems camelcase headers are installed by KF5::plasma into \
> include/KDE/Plasma/ but it should be a start...
>
> Diffs
> -----
>
> src/plasma/CMakeLists.txt b21fd7b
>
> Diff: http://git.reviewboard.kde.org/r/113139/diff/
>
>
> Testing
> -------
>
> In place on CI build system. Proper include path now given to compiler.
>
>
> Thanks,
>
> Ben Cooksley
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113139/">http://git.reviewboard.kde.org/r/113139/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 7th, 2013, 9:35 a.m. UTC, <b>Stephen \
Kelly</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113139/diff/1/?file=199605#file199605line173" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plasma/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">173</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">if</span><span class="p">(</span><span class="s">IS_ABSOLUTE</span> <span \
class="s2">"${INCLUDE_INSTALL_DIR}"</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The if-else \
shouldn't be needed. INSTALL_INTERFACE should already check if \
${INCLUDE_INSTALL_DIR} is absolute.</pre> </blockquote>
<p>On October 7th, 2013, 9:36 a.m. UTC, <b>Ben Cooksley</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I copied this code from \
KCoreAddons in kdelibs[frameworks]. Shall I correct it there as well?</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It appears \
in several other frameworks too. Actually your snippet is needed until CMake 2.8.12. \
I'll remove it from them all when kde requires that version.</pre> <br />
<p>- Stephen</p>
<br />
<p>On October 7th, 2013, 10:48 a.m. UTC, Ben Cooksley wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, Plasma and Stephen Kelly.</div>
<div>By Ben Cooksley.</div>
<p style="color: grey;"><i>Updated Oct. 7, 2013, 10:48 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add include targets for KF5::plasma, which will hopefully contribute \
towards fixing the kde-workspace[master] build on build.kde.org. Unfortunately it \
isn't entirely successful as it seems camelcase headers are installed by \
KF5::plasma into include/KDE/Plasma/ but it should be a start...</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In place on CI build system. Proper include path now given to \
compiler.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/CMakeLists.txt <span style="color: grey">(b21fd7b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113139/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic