This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113139/ |
On October 7th, 2013, 9:35 a.m. UTC, Stephen Kelly wrote:
src/plasma/CMakeLists.txt (Diff revision 1) 173 if(IS_ABSOLUTE "${INCLUDE_INSTALL_DIR}")The if-else shouldn't be needed. INSTALL_INTERFACE should already check if ${INCLUDE_INSTALL_DIR} is absolute.On October 7th, 2013, 9:36 a.m. UTC, Ben Cooksley wrote:
I copied this code from KCoreAddons in kdelibs[frameworks]. Shall I correct it there as well?
It appears in several other frameworks too. Actually your snippet is needed until CMake 2.8.12. I'll remove it from them all when kde requires that version.
- Stephen
On October 7th, 2013, 10:48 a.m. UTC, Ben Cooksley wrote:
Review request for kdelibs, Plasma and Stephen Kelly.
By Ben Cooksley.
Updated Oct. 7, 2013, 10:48 a.m.
Repository:
plasma-framework
Description
Testing
Diffs
|