[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113139: Try to export include targets for Plasma as well
From: "Ben Cooksley" <bcooksley () kde ! org>
Date: 2013-10-07 10:48:21
Message-ID: 20131007104821.27423.25283 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113139/
-----------------------------------------------------------
(Updated Oct. 7, 2013, 10:48 a.m.)
Status
------
This change has been marked as submitted.
Review request for kdelibs, Plasma and Stephen Kelly.
Repository: plasma-framework
Description
-------
Add include targets for KF5::plasma, which will hopefully contribute towards fixing \
the kde-workspace[master] build on build.kde.org. Unfortunately it isn't entirely \
successful as it seems camelcase headers are installed by KF5::plasma into \
include/KDE/Plasma/ but it should be a start...
Diffs
-----
src/plasma/CMakeLists.txt b21fd7b
Diff: http://git.reviewboard.kde.org/r/113139/diff/
Testing
-------
In place on CI build system. Proper include path now given to compiler.
Thanks,
Ben Cooksley
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113139/">http://git.reviewboard.kde.org/r/113139/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, Plasma and Stephen Kelly.</div>
<div>By Ben Cooksley.</div>
<p style="color: grey;"><i>Updated Oct. 7, 2013, 10:48 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add include targets for KF5::plasma, which will hopefully contribute \
towards fixing the kde-workspace[master] build on build.kde.org. Unfortunately it \
isn't entirely successful as it seems camelcase headers are installed by \
KF5::plasma into include/KDE/Plasma/ but it should be a start...</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In place on CI build system. Proper include path now given to \
compiler.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/CMakeLists.txt <span style="color: grey">(b21fd7b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113139/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic