[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Part II: cookie configuration dialog to support the accept cookie for session op
From: "David Faure" <faure () kde ! org>
Date: 2012-09-30 8:39:52
Message-ID: 20120930083952.30394.23471 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106619/#review19625
-----------------------------------------------------------
Ship it!
konqueror/settings/kio/kcookiespolicies.cpp
<http://git.reviewboard.kde.org/r/106619/#comment15624>
That's a weird variable name for an item... a bit confusing.
konqueror/settings/kio/kcookiespolicies.cpp
<http://git.reviewboard.kde.org/r/106619/#comment15625>
Use .value() instead of [] to prevent accidental insertion.
- David Faure
On Sept. 28, 2012, 4:46 a.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106619/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2012, 4:46 a.m.)
>
>
> Review request for KDE Base Apps.
>
>
> Description
> -------
>
> This is the configuration dialog portion of the patch necessary to convert the \
> global "Treat all cookies as session cookies" option into a per domain or per \
> cookie configuration. This patch completes the patch posted at \
> https://git.reviewboard.kde.org/r/106618/.
>
> This addresses bug 54300.
> http://bugs.kde.org/show_bug.cgi?id=54300
>
>
> Diffs
> -----
>
> konqueror/settings/kio/kcookiespolicies.h b035ad5
> konqueror/settings/kio/kcookiespolicies.cpp 75d265f
> konqueror/settings/kio/kcookiespolicies.ui 6b88b80
> konqueror/settings/kio/kcookiespolicyselectiondlg.h d40a0f2
> konqueror/settings/kio/kcookiespolicyselectiondlg.ui c7ebb5d
>
> Diff: http://git.reviewboard.kde.org/r/106619/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> New Cookie Config dialog
> http://git.reviewboard.kde.org/r/106619/s/737/
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106619/">http://git.reviewboard.kde.org/r/106619/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106619/diff/1/?file=87498#file87498line207" \
style="color: black; font-weight: bold; text-decoration: \
underline;">konqueror/settings/kio/kcookiespolicies.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KCookiesPolicies::changePressed()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">205</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QTreeWidgetItem</span><span class="o">*</span> <span class="n">index</span> \
<span class="o">=</span> <span class="n">mUi</span><span class="p">.</span><span \
class="n">lvDomainPolicy</span><span class="o">-></span><span \
class="n">currentItem</span><span class="p">();</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">177</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QTreeWidgetItem</span><span class="o">*</span> <span class="n">index</span> \
<span class="o">=</span> <span class="n">mUi</span><span class="p">.</span><span \
class="n">lvDomainPolicy</span><span class="o">-></span><span \
class="n">currentItem</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's \
a weird variable name for an item... a bit confusing.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106619/diff/1/?file=87498#file87498line216" \
style="color: black; font-weight: bold; text-decoration: \
underline;">konqueror/settings/kio/kcookiespolicies.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KCookiesPolicies::changePressed()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">214</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">pdlg</span><span class="p">.</span><span class="n">setPolicy</span> <span \
class="p">(</span><span class="n">KCookieAdvice</span><span class="o">::</span><span \
class="n">strToAdvice</span> <span class="p">(</span><span class="n">m<span \
class="hl">_p</span>DomainPolicy</span><span class="p">[</span><span \
class="n">index</span><span class="p">]));</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">186</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">pdlg</span><span class="p">.</span><span class="n">setPolicy</span> <span \
class="p">(</span><span class="n">KCookieAdvice</span><span class="o">::</span><span \
class="n">strToAdvice</span> <span class="p">(</span><span \
class="n">mDomainPolicy<span class="hl">Map</span></span><span \
class="p">[</span><span class="n">index</span><span class="p">]));</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use \
.value() instead of [] to prevent accidental insertion.</pre> </div>
<br />
<p>- David</p>
<br />
<p>On September 28th, 2012, 4:46 a.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Sept. 28, 2012, 4:46 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is the configuration dialog portion of the patch necessary to \
convert the global "Treat all cookies as session cookies" option into a per \
domain or per cookie configuration. This patch completes the patch posted at \
https://git.reviewboard.kde.org/r/106618/.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=54300">54300</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/settings/kio/kcookiespolicies.h <span style="color: \
grey">(b035ad5)</span></li>
<li>konqueror/settings/kio/kcookiespolicies.cpp <span style="color: \
grey">(75d265f)</span></li>
<li>konqueror/settings/kio/kcookiespolicies.ui <span style="color: \
grey">(6b88b80)</span></li>
<li>konqueror/settings/kio/kcookiespolicyselectiondlg.h <span style="color: \
grey">(d40a0f2)</span></li>
<li>konqueror/settings/kio/kcookiespolicyselectiondlg.ui <span style="color: \
grey">(c7ebb5d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106619/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106619/s/737/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/28/cookiejar_config_dialog_changes_400x100.png" \
style="border: 1px black solid;" alt="New Cookie Config dialog" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic