This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106619/

Ship it!

konqueror/settings/kio/kcookiespolicies.cpp (Diff revision 1)
void KCookiesPolicies::changePressed()
205	QTreeWidgetItem* index = mUi.lvDomainPolicy->currentItem();	177	QTreeWidgetItem* index = mUi.lvDomainPolicy->currentItem();

That's a weird variable name for an item... a bit confusing.

konqueror/settings/kio/kcookiespolicies.cpp (Diff revision 1)
void KCookiesPolicies::changePressed()
214	pdlg.setPolicy (KCookieAdvice::strToAdvice (m_pDomainPolicy[index]));	186	pdlg.setPolicy (KCookieAdvice::strToAdvice (mDomainPolicyMap[index]));

Use .value() instead of [] to prevent accidental insertion.

- David

On September 28th, 2012, 4:46 a.m., Dawit Alemayehu wrote:

Review request for KDE Base Apps.

By Dawit Alemayehu.

Updated Sept. 28, 2012, 4:46 a.m.

Description

This is the configuration dialog portion of the patch necessary to convert the global "Treat all cookies as session cookies" option into a per domain or per cookie configuration.  This patch completes the patch posted at https://git.reviewboard.kde.org/r/106618/.

Bugs: 54300

Diffs

konqueror/settings/kio/kcookiespolicies.h (b035ad5)
konqueror/settings/kio/kcookiespolicies.cpp (75d265f)
konqueror/settings/kio/kcookiespolicies.ui (6b88b80)
konqueror/settings/kio/kcookiespolicyselectiondlg.h (d40a0f2)
konqueror/settings/kio/kcookiespolicyselectiondlg.ui (c7ebb5d)

View Diff

Screenshots