--===============8902263651757126789== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106619/#review19625 ----------------------------------------------------------- Ship it! konqueror/settings/kio/kcookiespolicies.cpp That's a weird variable name for an item... a bit confusing. konqueror/settings/kio/kcookiespolicies.cpp Use .value() instead of [] to prevent accidental insertion. - David Faure On Sept. 28, 2012, 4:46 a.m., Dawit Alemayehu wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106619/ > ----------------------------------------------------------- > = > (Updated Sept. 28, 2012, 4:46 a.m.) > = > = > Review request for KDE Base Apps. > = > = > Description > ------- > = > This is the configuration dialog portion of the patch necessary to conver= t the global "Treat all cookies as session cookies" option into a per domai= n or per cookie configuration. This patch completes the patch posted at ht= tps://git.reviewboard.kde.org/r/106618/. > = > = > This addresses bug 54300. > http://bugs.kde.org/show_bug.cgi?id=3D54300 > = > = > Diffs > ----- > = > konqueror/settings/kio/kcookiespolicies.h b035ad5 = > konqueror/settings/kio/kcookiespolicies.cpp 75d265f = > konqueror/settings/kio/kcookiespolicies.ui 6b88b80 = > konqueror/settings/kio/kcookiespolicyselectiondlg.h d40a0f2 = > konqueror/settings/kio/kcookiespolicyselectiondlg.ui c7ebb5d = > = > Diff: http://git.reviewboard.kde.org/r/106619/diff/ > = > = > Testing > ------- > = > = > Screenshots > ----------- > = > New Cookie Config dialog > http://git.reviewboard.kde.org/r/106619/s/737/ > = > = > Thanks, > = > Dawit Alemayehu > = > --===============8902263651757126789== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106619/

Ship it!

= =
konqueror/settings/kio/kcookiespolicies.cpp (Diff revision 1) 
void KCookiesPolicies::changePressed()
205 
    QTreeWidgetItem* index =
=3D mUi.lvDomainPolicy->currentItem();
 177 
    QTreeWidgetItem* index =
=3D mUi.lvDomainPolicy->currentItem();
 
That's a weird variable name for an item... a bit confusing.

= =
konqueror/settings/kio/kcookiespolicies.cpp (Diff revision 1) 
void KCookiesPolicies::changePressed()
214 
    pdlg.setPolicy (KCookieAdvice::strToAdvice (m_pDomainPolicy[index]));
 186 
    pdlg.setPolicy (KCookieAdvice::strToAdvice (mDo=
mainPolicyMap[index]));
 
Use .value() instead of [] to prevent accidental insertion.

- David


On September 28th, 2012, 4:46 a.m., Dawit Alemayehu wrote:

Review request for KDE Base Apps.
By Dawit Alemayehu.

Updated Sept. 28, 2012, 4:46 a.m.

Descripti= on 

This is the configuration dialog portion of the patch necess=
ary to convert the global "Treat all cookies as session cookies" =
option into a per domain or per cookie configuration.  This patch completes=
 the patch posted at https://git.reviewboard.kde.org/r/106618/.
Bugs: 54300

Diffs=

  • konqueror/settings/kio/kcookiespolicies.h = (b035ad5)
  • konqueror/settings/kio/kcookiespolicies.cpp (6b88b80)
  • konqueror/settings/kio/kcookiespolicyselectiondlg.h (d40a0f2)
  • konqueror/settings/kio/kcookiespolicyselectiondlg.ui (c7ebb5d)

View Diff

Screensho= ts

3D"Ne=
--===============8902263651757126789==--