[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Part I: Add domain/cookie specific 'accept cookie for session' option to kcookie
From: "David Faure" <faure () kde ! org>
Date: 2012-09-30 8:36:43
Message-ID: 20120930083643.30244.96368 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106618/#review19622
-----------------------------------------------------------
Ship it!
Looks good. Just a few minor C++ things to fix before commit.
kioslave/http/kcookiejar/kcookiejar.h
<http://git.reviewboard.kde.org/r/106618/#comment15620>
remove trailing ';' (same on line below)
kioslave/http/kcookiejar/kcookiejar.h
<http://git.reviewboard.kde.org/r/106618/#comment15621>
Make the method const
kioslave/http/kcookiejar/kcookiejar.h
<http://git.reviewboard.kde.org/r/106618/#comment15622>
Make method const
- David Faure
On Sept. 28, 2012, 4:54 a.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106618/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2012, 4:54 a.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> This is a user contributed patch that changes the "Treat all cookies as session \
> cookies" global option into a per domain/cookie option so that the policy can be \
> configured in a more fine grained fashion. It was initially intended to be push \
> upstream for the 4.6 release, but for reasons I do not want to restate again, see \
> http://lists.kde.org/?t=132070395200003&r=1&w=2 if you want the details, the patch \
> never made it in.
> Well I want to push this into kdelibs for the 4.10 release before it is too late. \
> The patch comes complete with unit tests that exercise the new changes and was \
> contributed by Gregorio Guidi. He did all the work and made all the necessary fixes \
> based on feedback from me. I only added code to update the kcookiejar config file \
> and modified a couple of unrelated minor GUI issues. As such I want to reconginze \
> this effort by pushing this patch on his behalf.
>
> This addresses bug 54300.
> http://bugs.kde.org/show_bug.cgi?id=54300
>
>
> Diffs
> -----
>
> kioslave/http/kcookiejar/CMakeLists.txt e5ff3ee
> kioslave/http/kcookiejar/kcookiejar.h 896cab7
> kioslave/http/kcookiejar/kcookiejar.cpp db4606c
> kioslave/http/kcookiejar/kcookiescfg.pl PRE-CREATION
> kioslave/http/kcookiejar/kcookiescfg.upd 3c1cd02
> kioslave/http/kcookiejar/kcookieserver.cpp c8a61fb
> kioslave/http/kcookiejar/kcookiewin.h ce61c5a
> kioslave/http/kcookiejar/kcookiewin.cpp 0713cdd
> kioslave/http/kcookiejar/tests/cookie_session.test PRE-CREATION
> kioslave/http/kcookiejar/tests/cookie_settings.test 7fc1a03
> kioslave/http/kcookiejar/tests/kcookiejartest.cpp 5dbe2ca
>
> Diff: http://git.reviewboard.kde.org/r/106618/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> new cookie confirmation dialog
> http://git.reviewboard.kde.org/r/106618/s/736/
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106618/">http://git.reviewboard.kde.org/r/106618/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good. Just a few \
minor C++ things to fix before commit.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106618/diff/4/?file=87514#file87514line107" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kioslave/http/kcookiejar/kcookiejar.h</a> <span style="font-weight: \
normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">107</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KCookieAdvice</span> <span class="n">getUserSelectedAdvice</span><span \
class="p">()</span> <span class="k">const</span> <span class="p">{</span> <span \
class="k">return</span> <span class="n">mUserSelectedAdvice</span><span \
class="p">;</span> <span class="p">};</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">remove \
trailing ';' (same on line below)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106618/diff/4/?file=87514#file87514line214" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kioslave/http/kcookiejar/kcookiejar.h</a> <span style="font-weight: \
normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">214</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">bool</span> <span class="n">cookieIsPersistent</span><span \
class="p">(</span><span class="k">const</span> <span \
class="n">KHttpCookie</span><span class="o">&</span> <span \
class="n">cookie</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make the \
method const</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106618/diff/4/?file=87514#file87514line229" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kioslave/http/kcookiejar/kcookiejar.h</a> <span style="font-weight: \
normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">215</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KCookieAdvice</span> <span class="n">cookieAdvice</span><span \
class="p">(</span><span class="n">KHttpCookie</span><span class="o">&</span> \
<span class="n">cookie</span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">229</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KCookieAdvice</span> <span class="n">cookieAdvice</span><span \
class="p">(</span><span class="k"><span class="hl">const</span></span><span \
class="hl"> </span><span class="n">KHttpCookie</span><span class="o">&</span> \
<span class="n">cookie</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make method \
const</pre> </div>
<br />
<p>- David</p>
<br />
<p>On September 28th, 2012, 4:54 a.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Sept. 28, 2012, 4:54 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a user contributed patch that changes the "Treat all \
cookies as session cookies" global option into a per domain/cookie option so \
that the policy can be configured in a more fine grained fashion. It was initially \
intended to be push upstream for the 4.6 release, but for reasons I do not want to \
restate again, see http://lists.kde.org/?t=132070395200003&r=1&w=2 if you \
want the details, the patch never made it in.
Well I want to push this into kdelibs for the 4.10 release before it is too late. The \
patch comes complete with unit tests that exercise the new changes and was \
contributed by Gregorio Guidi. He did all the work and made all the necessary fixes \
based on feedback from me. I only added code to update the kcookiejar config file and \
modified a couple of unrelated minor GUI issues. As such I want to reconginze this \
effort by pushing this patch on his behalf.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=54300">54300</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/http/kcookiejar/CMakeLists.txt <span style="color: \
grey">(e5ff3ee)</span></li>
<li>kioslave/http/kcookiejar/kcookiejar.h <span style="color: \
grey">(896cab7)</span></li>
<li>kioslave/http/kcookiejar/kcookiejar.cpp <span style="color: \
grey">(db4606c)</span></li>
<li>kioslave/http/kcookiejar/kcookiescfg.pl <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kioslave/http/kcookiejar/kcookiescfg.upd <span style="color: \
grey">(3c1cd02)</span></li>
<li>kioslave/http/kcookiejar/kcookieserver.cpp <span style="color: \
grey">(c8a61fb)</span></li>
<li>kioslave/http/kcookiejar/kcookiewin.h <span style="color: \
grey">(ce61c5a)</span></li>
<li>kioslave/http/kcookiejar/kcookiewin.cpp <span style="color: \
grey">(0713cdd)</span></li>
<li>kioslave/http/kcookiejar/tests/cookie_session.test <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kioslave/http/kcookiejar/tests/cookie_settings.test <span style="color: \
grey">(7fc1a03)</span></li>
<li>kioslave/http/kcookiejar/tests/kcookiejartest.cpp <span style="color: \
grey">(5dbe2ca)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106618/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106618/s/736/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/28/new_cookiejar_ask_for_confirmation_dialog_400x100.png" \
style="border: 1px black solid;" alt="new cookie confirmation dialog" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic