[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: [PATCH] Change HTML thumbnail generator to
From: "Commit Hook" <null () kde ! org>
Date: 2011-12-06 22:55:33
Message-ID: 20111206225533.26960.2406 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101365/#review8774
-----------------------------------------------------------
This review has been submitted with commit 15481be78c527760fac1165cc8089f196ee3a7be \
by Dawit Alemayehu to branch master.
- Commit Hook
On Oct. 23, 2011, 4:19 p.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101365/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2011, 4:19 p.m.)
>
>
> Review request for KDE Runtime.
>
>
> Description
> -------
>
> This patch changes the thumbnail generate to use QtWebKit (through kdewebkit) such \
> that it can be used in the leaner mobile builds [1]. Note that this patch was \
> originally proposed to resolve http://bugs.kde.org/show_bug.cgi?id=248478, but that \
> issue has already been addressed. As such, this change is very optional.
> [1] http://lists.kde.org/?l=kde-core-devel&m=130813188205168&w=2.
>
>
> Diffs
> -----
>
> kioslave/thumbnail/CMakeLists.txt 9789109
> kioslave/thumbnail/htmlcreator.h 6903db7
> kioslave/thumbnail/htmlcreator.cpp c623606
>
> Diff: http://git.reviewboard.kde.org/r/101365/diff/diff
>
>
> Testing
> -------
>
> Tested by generating thumbnails on the Qt HTML documentation folder (thousands of \
> html files).
>
> Thanks,
>
> Dawit Alemayehu
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101365/">http://git.reviewboard.kde.org/r/101365/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 15481be78c527760fac1165cc8089f196ee3a7be by Dawit Alemayehu to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On October 23rd, 2011, 4:19 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Oct. 23, 2011, 4:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch changes the thumbnail generate to use QtWebKit (through \
kdewebkit) such that it can be used in the leaner mobile builds [1]. Note that this \
patch was originally proposed to resolve http://bugs.kde.org/show_bug.cgi?id=248478, \
but that issue has already been addressed. As such, this change is very optional.
[1] http://lists.kde.org/?l=kde-core-devel&m=130813188205168&w=2.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested by generating thumbnails on the Qt HTML documentation folder \
(thousands of html files).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/thumbnail/CMakeLists.txt <span style="color: \
grey">(9789109)</span></li>
<li>kioslave/thumbnail/htmlcreator.h <span style="color: grey">(6903db7)</span></li>
<li>kioslave/thumbnail/htmlcreator.cpp <span style="color: \
grey">(c623606)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101365/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic