From kde-core-devel Tue Dec 06 22:55:33 2011 From: "Commit Hook" Date: Tue, 06 Dec 2011 22:55:33 +0000 To: kde-core-devel Subject: Re: Review Request: [PATCH] Change HTML thumbnail generator to Message-Id: <20111206225533.26960.2406 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=132321227111845 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5942930658686774344==" --===============5942930658686774344== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101365/#review8774 ----------------------------------------------------------- This review has been submitted with commit 15481be78c527760fac1165cc8089f19= 6ee3a7be by Dawit Alemayehu to branch master. - Commit Hook On Oct. 23, 2011, 4:19 p.m., Dawit Alemayehu wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101365/ > ----------------------------------------------------------- > = > (Updated Oct. 23, 2011, 4:19 p.m.) > = > = > Review request for KDE Runtime. > = > = > Description > ------- > = > This patch changes the thumbnail generate to use QtWebKit (through kdeweb= kit) such that it can be used in the leaner mobile builds [1]. Note that th= is patch was originally proposed to resolve http://bugs.kde.org/show_bug.cg= i?id=3D248478, but that issue has already been addressed. As such, this cha= nge is very optional. > = > [1] http://lists.kde.org/?l=3Dkde-core-devel&m=3D130813188205168&w=3D2. > = > = > Diffs > ----- > = > kioslave/thumbnail/CMakeLists.txt 9789109 = > kioslave/thumbnail/htmlcreator.h 6903db7 = > kioslave/thumbnail/htmlcreator.cpp c623606 = > = > Diff: http://git.reviewboard.kde.org/r/101365/diff/diff > = > = > Testing > ------- > = > Tested by generating thumbnails on the Qt HTML documentation folder (thou= sands of html files). > = > = > Thanks, > = > Dawit Alemayehu > = > --===============5942930658686774344== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101365/ 

This revie=
w has been submitted with commit 15481be78c527760fac1165cc8089f196ee3a7be b=
y Dawit Alemayehu to branch master.

- Commit


On October 23rd, 2011, 4:19 p.m., Dawit Alemayehu wrote:

Review request for KDE Runtime.
By Dawit Alemayehu.

Updated Oct. 23, 2011, 4:19 p.m.

Descripti= on 

This patch changes the thumbnail generate to use QtWebKit (t=
hrough kdewebkit) such that it can be used in the leaner mobile builds [1].=
 Note that this patch was originally proposed to resolve http://bugs.kde.or=
g/show_bug.cgi?id=3D248478, but that issue has already been addressed. As s=
uch, this change is very optional.

[1] http://lists.kde.org/?l=3Dkde-core-devel&m=3D130813188205168&w=
=3D2.

Testing <= /h1> 
Tested by generating thumbnails on the Qt HTML documentation=
 folder (thousands of html files).

Diffs=

  • kioslave/thumbnail/CMakeLists.txt (9789109= )
  • kioslave/thumbnail/htmlcreator.h (6903db7)=
  • kioslave/thumbnail/htmlcreator.cpp (c62360= 6)

View Diff
--===============5942930658686774344==--