This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101365/

This review has been submitted with commit 15481be78c527760fac1165cc8089f196ee3a7be by Dawit Alemayehu to branch master.

- Commit


On October 23rd, 2011, 4:19 p.m., Dawit Alemayehu wrote:

Review request for KDE Runtime.
By Dawit Alemayehu.

Updated Oct. 23, 2011, 4:19 p.m.

Description

This patch changes the thumbnail generate to use QtWebKit (through kdewebkit) such that it can be used in the leaner mobile builds [1]. Note that this patch was originally proposed to resolve http://bugs.kde.org/show_bug.cgi?id=248478, but that issue has already been addressed. As such, this change is very optional.

[1] http://lists.kde.org/?l=kde-core-devel&m=130813188205168&w=2.

Testing

Tested by generating thumbnails on the Qt HTML documentation folder (thousands of html files).

Diffs

  • kioslave/thumbnail/CMakeLists.txt (9789109)
  • kioslave/thumbnail/htmlcreator.h (6903db7)
  • kioslave/thumbnail/htmlcreator.cpp (c623606)

View Diff