[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: optimize kcolorscheme consting time: avoid
From: "Nick Shaforostoff" <shafff () ukr ! net>
Date: 2011-12-06 23:00:39
Message-ID: 20111206230039.27140.1865 () vidsolbach ! de
[Download RAW message or body]
> On Dec. 6, 2011, 5:58 p.m., Nick Shaforostoff wrote:
> > I have an account called shaforo. i could push to kdepimlibs with it, b=
ut i couldn't push to kdelibs. is it because of lack of permissions?
> =
> Alexander Potashev wrote:
> You need to clone the `kdelibs` repo from `git@git.kde.org:kdelibs.gi=
t`. Check this in `kdelibs/.git/config` on your machine.
> =
> Albert Astals Cid wrote:
> kdelibs master is frozen because of the frameworks effort. You either=
commit it to the frameworks branch and wait until it's released or convinc=
e us this is a bugfix (which seems to be) and commit it to the 4.7 branch.
ok, so if nobody objects i will push it to 4.7 branch tomorrow
- Nick
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103348/#review8762
-----------------------------------------------------------
On Dec. 6, 2011, 5:53 p.m., Nick Shaforostoff wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103348/
> -----------------------------------------------------------
> =
> (Updated Dec. 6, 2011, 5:53 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Description
> -------
> =
> pretty straightforward and small optimization of kde apps startup time:
> avoid calculating luma for the same colors multiple times.
> =
> callgrind shows it is called 4503 times
> instead of 12087 at startup of kwrite, which is 1.5%.
> =
> =
> Diffs
> -----
> =
> kdeui/colors/kcolorutils.cpp efe8cdd =
> =
> Diff: http://git.reviewboard.kde.org/r/103348/diff/diff
> =
> =
> Testing
> -------
> =
> kwrite starts fine with the new kdeui lib
> =
> =
> Thanks,
> =
> Nick Shaforostoff
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103348/">http://git.reviewboard.kde.org/r/103348/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 6th, 2011, 5:58 p.m., <b>Nick \
Shaforostoff</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have an account called shaforo. i could push to kdepimlibs with it, \
but i couldn't push to kdelibs. is it because of lack of permissions?</pre> \
</blockquote>
<p>On December 6th, 2011, 6:11 p.m., <b>Alexander Potashev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You need to clone the \
`kdelibs` repo from `git@git.kde.org:kdelibs.git`. Check this in \
`kdelibs/.git/config` on your machine.</pre> </blockquote>
<p>On December 6th, 2011, 6:44 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kdelibs master is frozen \
because of the frameworks effort. You either commit it to the frameworks branch and \
wait until it's released or convince us this is a bugfix (which seems to be) and \
commit it to the 4.7 branch.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok, so if nobody objects \
i will push it to 4.7 branch tomorrow</pre> <br />
<p>- Nick</p>
<br />
<p>On December 6th, 2011, 5:53 p.m., Nick Shaforostoff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Nick Shaforostoff.</div>
<p style="color: grey;"><i>Updated Dec. 6, 2011, 5:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">pretty straightforward and small optimization of kde apps startup time: \
avoid calculating luma for the same colors multiple times.
callgrind shows it is called 4503 times
instead of 12087 at startup of kwrite, which is 1.5%.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kwrite starts fine with the new kdeui lib</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/colors/kcolorutils.cpp <span style="color: grey">(efe8cdd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103348/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic