[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: fix infinite recurssion in kcategorizedview
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-12-03 17:16:04
Message-ID: 20111203171604.8541.14384 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103313/#review8688
-----------------------------------------------------------
kdeui/itemviews/kcategorizedview.cpp
<http://git.reviewboard.kde.org/r/103313/#comment7321>
unused variable
kdeui/itemviews/kcategorizedview.cpp
<http://git.reviewboard.kde.org/r/103313/#comment7320>
i've not found any other range for the horizontal slider, thus one could unconditionally \
deactivate it (replacing this call)
- Thomas Lübking
On Dec. 3, 2011, 10:55 a.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103313/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2011, 10:55 a.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> Basically, what I do is:
> If there are one or zero columns, hide the horizontalScrollBar until it is needed. (it has \
> worked in the past, but in another file). Apply the same strategy with files.
>
> Additional stuff:
> Moved the common calculus of itemSize outside of the if then else.
>
>
> This addresses bugs 213068 and 287847.
> http://bugs.kde.org/show_bug.cgi?id=213068
> http://bugs.kde.org/show_bug.cgi?id=287847
>
>
> Diffs
> -----
>
> kdeui/itemviews/kcategorizedview.cpp 46a1cde
> kutils/kpluginselector.cpp ca0691d
>
> Diff: http://git.reviewboard.kde.org/r/103313/diff/diff
>
>
> Testing
> -------
>
> Krunner config does not loop (neither kgetnewstuff from kstars). I can not test with amarok \
> (I've hit by an amarok start bug). Please, test with other programs.
>
>
> Thanks,
>
> Jaime Torres Amate
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103313/">http://git.reviewboard.kde.org/r/103313/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; \
padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103313/diff/2/?file=42637#file42637line495" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdeui/itemviews/kcategorizedview.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KCategorizedView::Private::topToBottomVisualRect(const QModelIndex &index, Item \
&item,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">495</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "> <span class="k">const</span> <span \
class="n">QSize</span> <span class="n">currSize</span> <span class="o">=</span> <span \
class="n">q</span><span class="o">-></span><span class="n">sizeHintForIndex</span><span \
class="p">(</span><span class="n">index</span><span class="p">);</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">495</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n">QSize</span> <span class="n">currSize</span> <span \
class="o">=</span> <span class="n">q</span><span class="o">-></span><span \
class="n">sizeHintForIndex</span><span class="p">(</span><span class="n">index</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unused variable</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; \
padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103313/diff/2/?file=42637#file42637line1421" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdeui/itemviews/kcategorizedview.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KCategorizedView::updateGeometries()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">1403</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "> <span class="n">horizontalScrollBar</span><span \
class="p">()</span><span class="o">-></span><span class="n">setRange</span><span \
class="p">(</span><span class="mi">0</span><span class="p">,</span> <span \
class="mi">0</span><span class="p">);</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">1417</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "> <span class="n">horizontalScrollBar</span><span \
class="p">()</span><span class="o">-></span><span class="n">setRange</span><span \
class="p">(</span><span class="mi">0</span><span class="p">,</span> <span \
class="mi">0</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i've not found any other range \
for the horizontal slider, thus one could unconditionally deactivate it (replacing this \
call)</pre> </div>
<br />
<p>- Thomas</p>
<br />
<p>On December 3rd, 2011, 10:55 a.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2011, 10:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Basically, what I do \
is: If there are one or zero columns, hide the horizontalScrollBar until it is needed. (it has \
worked in the past, but in another file). Apply the same strategy with files.
Additional stuff:
Moved the common calculus of itemSize outside of the if then else.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Krunner config does \
not loop (neither kgetnewstuff from kstars). I can not test with amarok (I've hit by an \
amarok start bug). Please, test with other programs.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=213068">213068</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=287847">287847</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/itemviews/kcategorizedview.cpp <span style="color: grey">(46a1cde)</span></li>
<li>kutils/kpluginselector.cpp <span style="color: grey">(ca0691d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103313/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic