From kde-core-devel Sat Dec 03 17:16:04 2011 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Sat, 03 Dec 2011 17:16:04 +0000 To: kde-core-devel Subject: Re: Review Request: fix infinite recurssion in kcategorizedview Message-Id: <20111203171604.8541.14384 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=132293268226120 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6727736983087064657==" --===============6727736983087064657== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103313/#review8688 ----------------------------------------------------------- kdeui/itemviews/kcategorizedview.cpp unused variable kdeui/itemviews/kcategorizedview.cpp i've not found any other range for the horizontal slider, thus one coul= d unconditionally deactivate it (replacing this call) - Thomas L=C3=BCbking On Dec. 3, 2011, 10:55 a.m., Jaime Torres Amate wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103313/ > ----------------------------------------------------------- > = > (Updated Dec. 3, 2011, 10:55 a.m.) > = > = > Review request for kdelibs. > = > = > Description > ------- > = > Basically, what I do is: > If there are one or zero columns, hide the horizontalScrollBar until it i= s needed. (it has worked in the past, but in another file). > Apply the same strategy with files. > = > Additional stuff: > Moved the common calculus of itemSize outside of the if then else. > = > = > This addresses bugs 213068 and 287847. > http://bugs.kde.org/show_bug.cgi?id=3D213068 > http://bugs.kde.org/show_bug.cgi?id=3D287847 > = > = > Diffs > ----- > = > kdeui/itemviews/kcategorizedview.cpp 46a1cde = > kutils/kpluginselector.cpp ca0691d = > = > Diff: http://git.reviewboard.kde.org/r/103313/diff/diff > = > = > Testing > ------- > = > Krunner config does not loop (neither kgetnewstuff from kstars). I can no= t test with amarok (I've hit by an amarok start bug). > Please, test with other programs. > = > = > Thanks, > = > Jaime Torres Amate > = > --===============6727736983087064657== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103313/

= =
kdeui/itemviews/kcategorizedview.cpp (Diff revision 2) 
void KCategorizedView::Private::topToBottomVisualRect(const QModelI=
ndex &index, Item &item,
495 
                const=
 QSize currSize =3D q->sizeHintForIndex(index);
 495 
                const=
 QSize currSize =3D q->sizeHintForIndex(index);
 
unused variable

= =
kdeui/itemviews/kcategorizedview.cpp (Diff revision 2) 
void KCategorizedView::updateGeometries()
1403 
    horizontalScrollBar()->setRange(0, 0);
 1417 
    horizontalScrollBar()->setRange(0, 0);
 
i've not found any other range for the horizontal slider, thus o=
ne could unconditionally deactivate it (replacing this call)

- Thomas


On December 3rd, 2011, 10:55 a.m., Jaime Torres Amate wrote:

Review request for kdelibs.
By Jaime Torres Amate.

Updated Dec. 3, 2011, 10:55 a.m.

Descripti= on 

Basically, what I do is:
If there are one or zero columns, hide the horizontalScrollBar until it is =
needed. (it has worked in the past, but in another file).
Apply the same strategy with files.

Additional stuff:
Moved the common calculus of itemSize outside of the if then else.

Testing <= /h1> 
Krunner config does not loop (neither kgetnewstuff from ksta=
rs). I can not test with amarok (I've hit by an amarok start bug).
Please, test with other programs.
Bugs: 213068, = 287847

Diffs=

  • kdeui/itemviews/kcategorizedview.cpp (46a1= cde)
  • kutils/kpluginselector.cpp (ca0691d)

View Diff
--===============6727736983087064657==--