This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103313/

kdeui/itemviews/kcategorizedview.cpp (Diff revision 2) 
void KCategorizedView::Private::topToBottomVisualRect(const QModelIndex &index, Item &item,
495 
                const QSize currSize = q->sizeHintForIndex(index);
 495 
                const QSize currSize = q->sizeHintForIndex(index);
 
unused variable

kdeui/itemviews/kcategorizedview.cpp (Diff revision 2) 
void KCategorizedView::updateGeometries()
1403 
    horizontalScrollBar()->setRange(0, 0);
 1417 
    horizontalScrollBar()->setRange(0, 0);
 
i've not found any other range for the horizontal slider, thus one could unconditionally deactivate it (replacing this call)

- Thomas


On December 3rd, 2011, 10:55 a.m., Jaime Torres Amate wrote:

Review request for kdelibs.
By Jaime Torres Amate.

Updated Dec. 3, 2011, 10:55 a.m.

Description 

Basically, what I do is:
If there are one or zero columns, hide the horizontalScrollBar until it is needed. (it has worked in the past, but in another file).
Apply the same strategy with files.

Additional stuff:
Moved the common calculus of itemSize outside of the if then else.

Testing 

Krunner config does not loop (neither kgetnewstuff from kstars). I can not test with amarok (I've hit by an amarok start bug).
Please, test with other programs.
Bugs: 213068, 287847

Diffs

  • kdeui/itemviews/kcategorizedview.cpp (46a1cde)
  • kutils/kpluginselector.cpp (ca0691d)

View Diff