[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add git support to kdesdk: create_tarball.rb
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2011-12-03 14:52:24
Message-ID: 20111203145224.27110.36205 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6842/#review10511
-----------------------------------------------------------
Ship it!
The changes seem very minor, and from what i can see they will not "break" =
the svn support, so just go for it if it works for you. =
We can fix any new issues in git support as they arise.
- Albert Astals Cid
On Nov. 29, 2011, 4:42 p.m., K=C3=A5re S=C3=A4rs wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6842/
> -----------------------------------------------------------
> =
> (Updated Nov. 29, 2011, 4:42 p.m.)
> =
> =
> Review request for kdelibs and Release Team.
> =
> =
> Description
> -------
> =
> This patch adds git support to create_tarball.rb in kdesdk. The patch add=
s two options to the ini file. The first one (gitModule) indicates that the=
module is located in git and the second optional parameter (gitTag) define=
s which tag to use for creating the release. (there is no group for kdesdk =
or extragear)
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdesdk/scripts/createtarball/config.ini 1266277 =
> trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb 1266277 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6842/diff/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> K=C3=A5re S=C3=A4rs
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6842/">http://svn.reviewboard.kde.org/r/6842/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">The changes seem very minor, and from what i \
can see they will not "break" the svn support, so just go for it if it works for you. \
We can fix any new issues in git support as they arise.</pre>
<br />
<p>- Albert</p>
<br />
<p>On November 29th, 2011, 4:42 p.m., Kåre Särs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kdelibs and Release Team.</div>
<div>By Kåre Särs.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2011, 4:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds git \
support to create_tarball.rb in kdesdk. The patch adds two options to the ini file. The first \
one (gitModule) indicates that the module is located in git and the second optional parameter \
(gitTag) defines which tag to use for creating the release. (there is no group for kdesdk or \
extragear)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdesdk/scripts/createtarball/config.ini <span style="color: \
grey">(1266277)</span></li>
<li>trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb <span style="color: \
grey">(1266277)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6842/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic