[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: new kded daemon to check .thumbnail directory
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2011-09-21 19:37:59
Message-ID: 20110921193759.21872.33541 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102083/
-----------------------------------------------------------
(Updated Sept. 21, 2011, 7:37 p.m.)
Review request for kdelibs.
Changes
-------
Done a lot of improvements, like:
* I was using a QList as a queue, now use a Queue.
* It is now ready to handle more than one directory to check. (the previous patch had \
some problems :-(). I know now what the Notify Contexts are. They need a little more \
information in the documentation :-)
* It only deletes regular files, otherwise it is too risky (I've deleted my home \
directory in the development process some times, not anymore).
* fixed Christoph warnings, except one.
* The suffix MiB or MB
because as you have seen in all this years, I'm not good at GUI programming (yet).
If someone is able to create a configuration to add/remove/select more than one \
directory, the maximum space allowed, and if it will be deleted automatically or not, \
and also change the configuration read/save, it will be able to work with more than \
one directory. At the moment, only $HOME/.thumbnails.
Summary (updated)
-------
Checks the head of a queue of directories every x minutes (default 30) to see if this \
directory (and children) use more space than the allowed (default 512 Mib). If so, it \
shows a notification allowing the user to clean the oldest files, open the file \
manager, or configure the daemon (time to wait for the next directory, delete \
automatically...).
This addresses bug 79943.
http://bugs.kde.org/show_bug.cgi?id=79943
Diffs (updated)
-----
CMakeLists.txt 1d7c637
directoryusagenotifier/CMakeLists.txt PRE-CREATION
directoryusagenotifier/COPYING PRE-CREATION
directoryusagenotifier/Messages.sh PRE-CREATION
directoryusagenotifier/README PRE-CREATION
directoryusagenotifier/cleanupdirectory.h PRE-CREATION
directoryusagenotifier/cleanupdirectory.cpp PRE-CREATION
directoryusagenotifier/directoryusagenotifier.h PRE-CREATION
directoryusagenotifier/directoryusagenotifier.cpp PRE-CREATION
directoryusagenotifier/directoryusagenotifier.desktop PRE-CREATION
directoryusagenotifier/directoryusagenotifier.kcfg PRE-CREATION
directoryusagenotifier/directoryusagenotifier.notifyrc PRE-CREATION
directoryusagenotifier/directoryusagenotifier_config.cpp PRE-CREATION
directoryusagenotifier/directoryusagenotifier_prefs_base.ui PRE-CREATION
directoryusagenotifier/module.h PRE-CREATION
directoryusagenotifier/module.cpp PRE-CREATION
directoryusagenotifier/settings.kcfgc PRE-CREATION
directoryusagenotifier/tests/CMakeLists.txt PRE-CREATION
directoryusagenotifier/tests/cleanupunittest.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/102083/diff
Testing (updated)
-------
It works as expected.
It shows the notification, and deletes the oldest files in the .thumbnail directory \
until the files left use less or equal space than the specified.
Thanks,
Jaime Torres
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102083/">http://git.reviewboard.kde.org/r/102083/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Sept. 21, 2011, 7:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Done a lot of improvements, like:
* I was using a QList as a queue, now use a Queue.
* It is now ready to handle more than one directory to check. (the previous patch had \
some problems :-(). I know now what the Notify Contexts are. They need a little more \
information in the documentation :-)
* It only deletes regular files, otherwise it is too risky (I've deleted my home \
directory in the development process some times, not anymore).
* fixed Christoph warnings, except one.
* The suffix MiB or MB
because as you have seen in all this years, I'm not good at GUI programming \
(yet). If someone is able to create a configuration to add/remove/select more than \
one directory, the maximum space allowed, and if it will be deleted automatically or \
not, and also change the configuration read/save, it will be able to work with more \
than one directory. At the moment, only $HOME/.thumbnails.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Checks the head of a queue of directories every x minutes (default 30) \
to see if this directory (and children) use more space than the allowed (default 512 \
Mib). If so, it shows a notification allowing the user to clean the oldest files, \
open the file manager, or configure the daemon (time to wait for the next directory, \
delete automatically...).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works as expected. It shows the notification, and deletes the oldest \
files in the .thumbnail directory until the files left use less or equal space than \
the specified.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=79943">79943</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(1d7c637)</span></li>
<li>directoryusagenotifier/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/COPYING <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/README <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/cleanupdirectory.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/cleanupdirectory.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier.kcfg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier.notifyrc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier_config.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier_prefs_base.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/module.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/module.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/settings.kcfgc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/tests/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/tests/cleanupunittest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102083/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic