From kde-core-devel Wed Sep 21 19:37:59 2011 From: "Jaime Torres Amate" Date: Wed, 21 Sep 2011 19:37:59 +0000 To: kde-core-devel Subject: Re: Review Request: new kded daemon to check .thumbnail directory Message-Id: <20110921193759.21872.33541 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=131663390417886 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7113336396270850691==" --===============7113336396270850691== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102083/ ----------------------------------------------------------- (Updated Sept. 21, 2011, 7:37 p.m.) Review request for kdelibs. Changes ------- Done a lot of improvements, like: * I was using a QList as a queue, now use a Queue. * It is now ready to handle more than one directory to check. (the previous= patch had some problems :-(). I know now what the Notify Contexts are. They need a little more informat= ion in the documentation :-) * It only deletes regular files, otherwise it is too risky (I've deleted my= home directory in the development process some times, not anymore). * fixed Christoph warnings, except one. * The suffix MiB or MB because as you have seen in all this years, I'm not good at GUI programming= (yet). If someone is able to create a configuration to add/remove/select more th= an one directory, the maximum space allowed, and if it will be deleted auto= matically or not, and also change the configuration read/save, it will be a= ble to work with more than one directory. = At the moment, only $HOME/.thumbnails. Summary (updated) ------- Checks the head of a queue of directories every x minutes (default 30) to s= ee if this directory (and children) use more space than the allowed (defaul= t 512 Mib). If so, it shows a notification allowing the user to clean the o= ldest files, open the file manager, or configure the daemon (time to wait f= or the next directory, delete automatically...). This addresses bug 79943. http://bugs.kde.org/show_bug.cgi?id=3D79943 Diffs (updated) ----- CMakeLists.txt 1d7c637 = directoryusagenotifier/CMakeLists.txt PRE-CREATION = directoryusagenotifier/COPYING PRE-CREATION = directoryusagenotifier/Messages.sh PRE-CREATION = directoryusagenotifier/README PRE-CREATION = directoryusagenotifier/cleanupdirectory.h PRE-CREATION = directoryusagenotifier/cleanupdirectory.cpp PRE-CREATION = directoryusagenotifier/directoryusagenotifier.h PRE-CREATION = directoryusagenotifier/directoryusagenotifier.cpp PRE-CREATION = directoryusagenotifier/directoryusagenotifier.desktop PRE-CREATION = directoryusagenotifier/directoryusagenotifier.kcfg PRE-CREATION = directoryusagenotifier/directoryusagenotifier.notifyrc PRE-CREATION = directoryusagenotifier/directoryusagenotifier_config.cpp PRE-CREATION = directoryusagenotifier/directoryusagenotifier_prefs_base.ui PRE-CREATION = directoryusagenotifier/module.h PRE-CREATION = directoryusagenotifier/module.cpp PRE-CREATION = directoryusagenotifier/settings.kcfgc PRE-CREATION = directoryusagenotifier/tests/CMakeLists.txt PRE-CREATION = directoryusagenotifier/tests/cleanupunittest.cpp PRE-CREATION = Diff: http://git.reviewboard.kde.org/r/102083/diff Testing (updated) ------- It works as expected. It shows the notification, and deletes the oldest files in the .thumbnail d= irectory until the files left use less or equal space than the specified. Thanks, Jaime Torres --===============7113336396270850691== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102083/

Review request for kdelibs.
By Jaime Torres Amate.

Updated Sept. 21, 2011, 7:37 p.m.

Changes
Done a lot of improvements, like:
* I was using a QList as a queue, now use a Queue.
* It is now ready to handle more than one directory to check. (the previous=
 patch had some problems :-().
  I know now what the Notify Contexts are. They need a little more informat=
ion in the documentation :-)
* It only deletes regular files, otherwise it is too risky (I've delete=
d my home directory in the development process some times, not anymore).
* fixed Christoph warnings, except one.
  * The suffix MiB or MB
because as you have seen in all this years, I'm not good at GUI program=
ming (yet).
  If someone is able to create a configuration to add/remove/select more th=
an one directory, the maximum space allowed, and if it will be deleted auto=
matically or not, and also change the configuration read/save, it will be a=
ble to work with more than one directory. =

At the moment, only $HOME/.thumbnails.

Descripti= on (updated)

Checks the head of a queue of directories every x minutes (d=
efault 30) to see if this directory (and children) use more space than the =
allowed (default 512 Mib). If so, it shows a notification allowing the user=
 to clean the oldest files, open the file manager, or configure the daemon =
(time to wait for the next directory, delete automatically...).

Testing (= updated)

It works as expected.
It shows the notification, and deletes the oldest files in the .thumbnail d=
irectory until the files left use less or equal space than the specified.
  
Bugs: 79943

Diffs= (updated)

  • CMakeLists.txt (1d7c637)
  • directoryusagenotifier/CMakeLists.txt (PRE= -CREATION)
  • directoryusagenotifier/COPYING (PRE-CREATI= ON)
  • directoryusagenotifier/Messages.sh (PRE-CR= EATION)
  • directoryusagenotifier/README (PRE-CREATIO= N)
  • directoryusagenotifier/cleanupdirectory.h = (PRE-CREATION)
  • directoryusagenotifier/cleanupdirectory.cpp (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier.cpp (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier.desktop (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier.kcfg (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier.notifyrc (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier_config.cpp (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier_prefs_base.ui (PRE-CREATION)
  • directoryusagenotifier/module.h (PRE-CREAT= ION)
  • directoryusagenotifier/module.cpp (PRE-CRE= ATION)
  • directoryusagenotifier/settings.kcfgc (PRE= -CREATION)
  • directoryusagenotifier/tests/CMakeLists.txt (PRE-CREATION)

View Diff

--===============7113336396270850691==--