'Re: Review Request: rate control in ftp kio slave with review'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: rate control in ftp kio slave with review
From:       "Tushar Mehta" <mehtatus () gmail ! com>
Date:       2011-09-21 19:15:15
Message-ID: 20110921191515.20883.82161 () vidsolbach ! de
[Download RAW message or body]

> On Sept. 21, 2011, 1:58 p.m., Christoph Feck wrote:
> > Oh, you opened a new review instead of updating it :) Please close/disc=
ard the old review request.

I closed the old review request. :)


- Tushar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102307/#review6703
-----------------------------------------------------------


On Aug. 11, 2011, 4:16 p.m., Tushar Mehta wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102307/
> -----------------------------------------------------------
> =

> (Updated Aug. 11, 2011, 4:16 p.m.)
> =

> =

> Review request for kdelibs, Dawit Alemayehu, David Faure, Thiago Macieira=
, Thomas Zander, and Lukas Appelhans.
> =

> =

> Summary
> -------
> =

> This patch is trying to clear the comments of the previous patch.(https:/=
/git.reviewboard.kde.org/r/102307/)
> =

> =

> Diffs
> -----
> =

>   kioslave/ftp/CMakeLists.txt e080b02 =

>   kioslave/ftp/ftp.cpp 655524a =

>   kioslave/ftp/ratecontroller.h PRE-CREATION =

>   kioslave/ftp/ratecontroller.cpp PRE-CREATION =

>   kioslave/ftp/speedController.h PRE-CREATION =

>   kioslave/ftp/speedController.cpp PRE-CREATION =

> =

> Diff: http://git.reviewboard.kde.org/r/102307/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Tushar
> =

>


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102307/">http://git.reviewboard.kde.org/r/102307/</a>
  </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On September 21st, 2011, 1:58 p.m., <b>Christoph \
Feck</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Oh, you opened a new review instead of updating it :) Please \
close/discard the old review request.</pre>  </blockquote>







</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I closed the old review \
request. :)</pre> <br />








<p>- Tushar</p>


<br />
<p>On August 11th, 2011, 4:16 p.m., Tushar Mehta wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs, Dawit Alemayehu, David Faure, Thiago Macieira, \
Thomas Zander, and Lukas Appelhans.</div> <div>By Tushar Mehta.</div>


<p style="color: grey;"><i>Updated Aug. 11, 2011, 4:16 p.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is trying to clear the comments of the previous \
patch.(https://git.reviewboard.kde.org/r/102307/)</pre>  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kioslave/ftp/CMakeLists.txt <span style="color: grey">(e080b02)</span></li>

 <li>kioslave/ftp/ftp.cpp <span style="color: grey">(655524a)</span></li>

 <li>kioslave/ftp/ratecontroller.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kioslave/ftp/ratecontroller.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kioslave/ftp/speedController.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kioslave/ftp/speedController.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102307/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic