[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Improvements to KFileDialog filtering
From: "Commit Hook" <null () kde ! org>
Date: 2011-04-19 4:33:08
Message-ID: 20110419043308.1179.89049 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101013/#review2746
-----------------------------------------------------------
This review has been submitted with commit 6344c4f0505f7a0994bd7f36e5c607959d2dfbcf \
by Parker Coates.
- Commit
On April 2, 2011, 11:47 p.m., Parker Coates wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101013/
> -----------------------------------------------------------
>
> (Updated April 2, 2011, 11:47 p.m.)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> This patch attempts to improve the usefulness and usability of KFileDialog's filter \
> field when in Opening mode.
> Firstly, if the filter text isn't: * the display name of one of the filters passed \
> to the dialog or
> * one or more space separated mimetype specifiers (containing a '/') or
> * one or more space separated file globs (containing '*', '?' or "[.*]")
> we convert the text to a glob by prepending and appending asterisks. This lets the \
> user enter a piece of text (without having to know any glob patterns) and see only \
> the files whose names contain that text, much the same as they would when filtering \
> in Dolphin.
> Secondly, the filtering updates on the fly as the filter text is typed. Previously, \
> the filtering updated only when Return was pressed, which differs from the \
> behaviour of most of KDE's other filter boxes. The old behaviour is especially \
> confusing when one clicks the small clear button embedded in the combobox, because \
> it clears the box, but the filtering is unchanged until the user goes to the \
> keyboard to press enter.
>
> This addresses bug 142900.
> http://bugs.kde.org/show_bug.cgi?id=142900
>
>
> Diffs
> -----
>
> kfile/kfilewidget.cpp 9b8cdeb
>
> Diff: http://git.reviewboard.kde.org/r/101013/diff
>
>
> Testing
> -------
>
> I've played around with it a fair bit and it seems to work fine. I've never really \
> worked with this code before, so if I'm doing something silly please let me know.
>
> Thanks,
>
> Parker
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101013/">http://git.reviewboard.kde.org/r/101013/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 6344c4f0505f7a0994bd7f36e5c607959d2dfbcf by Parker \
Coates.</pre> <br />
<p>- Commit</p>
<br />
<p>On April 2nd, 2011, 11:47 p.m., Parker Coates wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Parker Coates.</div>
<p style="color: grey;"><i>Updated April 2, 2011, 11:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch attempts to improve the usefulness and usability of \
KFileDialog's filter field when in Opening mode.
Firstly, if the filter text isn't: * the display name of one of the filters \
passed to the dialog or
* one or more space separated mimetype specifiers \
(containing a '/') or
* one or more space separated file globs \
(containing '*', '?' or "[.*]") we convert the text to a \
glob by prepending and appending asterisks. This lets the user enter a piece of text \
(without having to know any glob patterns) and see only the files whose names contain \
that text, much the same as they would when filtering in Dolphin.
Secondly, the filtering updates on the fly as the filter text is typed. Previously, \
the filtering updated only when Return was pressed, which differs from the behaviour \
of most of KDE's other filter boxes. The old behaviour is especially confusing \
when one clicks the small clear button embedded in the combobox, because it clears \
the box, but the filtering is unchanged until the user goes to the keyboard to press \
enter.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've played around with it a fair bit and it seems to work fine. \
I've never really worked with this code before, so if I'm doing something \
silly please let me know.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=142900">142900</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kfile/kfilewidget.cpp <span style="color: grey">(9b8cdeb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101013/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic