[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Using KWallet to store Cookies
From: Dawit A <adawit () kde ! org>
Date: 2011-04-19 4:05:05
Message-ID: BANLkTikhYq1jD3dwgivP0KU9cOUq-FFzCg () mail ! gmail ! com
[Download RAW message or body]
Would you be able to create a new request in git.reviewboard.kde.org for
this so that it won't fall through the cracks ? Perhaps there is still a
chance for this making the KDE 4.7 release. The only reservation I have is
the ability to unit test things when cookies are stored in the kwallet. Hav=
e
you been able to run the extensive kcookiejar unit tests under such a setup
?
Also you would need to split the GUI configuration from the non-gui portion
if you plan to resubmit into the new reviewboard. Anyhow, I would be willin=
g
to give it a try and review it again if you are inclined to do so...
2011/1/21 Jos=C3=A9 Mill=C3=A1n Soto <fid@gpul.org>
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/4927/
> Review request for kdelibs.
> By Jos=C3=A9 Mill=C3=A1n Soto.
>
> *Updated Jan. 21, 2011, 5:37 p.m.*
> Changes
>
> New version of the patch.
> Instead of using QEventLoop, delayed DBus messages are used.
>
> Description
>
> Currently cookies are stored in a plain text file. This patch allows KCoo=
kieJar to store the cookies securely using KWallet.
>
> The main problem I had writing this patch was that when a web page is req=
uested, KIO ask for the cookies to kded using dbus. In the first implementa=
tions that I wrote, if the user took too long to open the wallet, KIO recei=
ved a dbus timeout.
>
> To prevent this, if it takes more than 10 seconds to open the wallet, the=
web page will be requested without sending the cookies (or sending the ava=
ilable cookies if there's still the plain text cookie file). If the wallet =
is opened after that, the cookies stored in the wallet will be available si=
nce then.
>
> Because of this, the feature is disabled by default.
>
> Diffs (updated)
>
> - /trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiespolicies.cpp
> (1215885)
> - /trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiespoliciesdlg.u=
i
> (1215885)
> - /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.h (1215938)
> - /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp (1215938)
> - /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.h (1215938=
)
> - /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp
> (1215938)
>
> View Diff <http://svn.reviewboard.kde.org/r/4927/diff/>
>
[Attachment #3 (text/html)]
Would you be able to create a new request in <a \
href="http://git.reviewboard.kde.org">git.reviewboard.kde.org</a> for this so that it \
won't fall through the cracks ? Perhaps there is still a chance for this making \
the KDE 4.7 release. The only reservation I have is the ability to unit test things \
when cookies are stored in the kwallet. Have you been able to run the extensive \
kcookiejar unit tests under such a setup ? <div>
<br></div><div>Also you would need to split the GUI configuration from the non-gui \
portion if you plan to resubmit into the new reviewboard. Anyhow, I would be willing \
to give it a try and review it again if you are inclined to do so...<br>
<br><div class="gmail_quote">2011/1/21 José Millán Soto <span dir="ltr"><<a \
href="mailto:fid@gpul.org">fid@gpul.org</a>></span><br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex;">
<div>
<div style="font-family:Verdana, Arial, Helvetica, Sans-Serif"><div class="im">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 \
solid"> <tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/4927/" \
target="_blank">http://svn.reviewboard.kde.org/r/4927/</a> </td>
</tr>
</tbody></table>
<br>
</div><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-repeat:repeat-x;border:1px black solid"> <tbody><tr>
<td><div class="im">
<div>Review request for kdelibs.</div>
<div>By José Millán Soto.</div>
</div><p style="color:grey"><i>Updated Jan. 21, 2011, 5:37 p.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">New \
version of the patch. Instead of using QEventLoop, delayed DBus messages are \
used.</pre> </td>
</tr>
</tbody></table><div class="im">
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Currently \
cookies are stored in a plain text file. This patch allows KCookieJar to store the \
cookies securely using KWallet.
The main problem I had writing this patch was that when a web page is requested, KIO \
ask for the cookies to kded using dbus. In the first implementations that I wrote, if \
the user took too long to open the wallet, KIO received a dbus timeout.
To prevent this, if it takes more than 10 seconds to open the wallet, the web page \
will be requested without sending the cookies (or sending the available cookies if \
there's still the plain text cookie file). If the wallet is opened after that, \
the cookies stored in the wallet will be available since then.
Because of this, the feature is disabled by default.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs (updated)</h1>
</div><ul style="margin-left:3em;padding-left:0">
<li>/trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiespolicies.cpp <span \
style="color:grey">(1215885)</span></li>
<li>/trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiespoliciesdlg.ui <span \
style="color:grey">(1215885)</span></li>
<li>/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.h <span \
style="color:grey">(1215938)</span></li>
<li>/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp <span \
style="color:grey">(1215938)</span></li>
<li>/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.h <span \
style="color:grey">(1215938)</span></li>
<li>/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp <span \
style="color:grey">(1215938)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/4927/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div>
</div>
</blockquote></div><br></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic