From kde-core-devel Tue Apr 19 04:33:08 2011 From: "Commit Hook" Date: Tue, 19 Apr 2011 04:33:08 +0000 To: kde-core-devel Subject: Re: Review Request: Improvements to KFileDialog filtering Message-Id: <20110419043308.1179.89049 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=130322901611321 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4721733783361230175==" --===============4721733783361230175== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101013/#review2746 ----------------------------------------------------------- This review has been submitted with commit 6344c4f0505f7a0994bd7f36e5c60795= 9d2dfbcf by Parker Coates. - Commit On April 2, 2011, 11:47 p.m., Parker Coates wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101013/ > ----------------------------------------------------------- > = > (Updated April 2, 2011, 11:47 p.m.) > = > = > Review request for kdelibs. > = > = > Summary > ------- > = > This patch attempts to improve the usefulness and usability of KFileDialo= g's filter field when in Opening mode. > = > Firstly, if the filter text isn't: * the display name of one of the filte= rs passed to the dialog or > * one or more space separated mimetype= specifiers (containing a '/') or > * one or more space separated file glo= bs (containing '*', '?' or "[.*]") > we convert the text to a glob by prepending and appending asterisks. This= lets the user enter a piece of text (without having to know any glob patte= rns) and see only the files whose names contain that text, much the same as= they would when filtering in Dolphin. > = > Secondly, the filtering updates on the fly as the filter text is typed. P= reviously, the filtering updated only when Return was pressed, which differ= s from the behaviour of most of KDE's other filter boxes. The old behaviour= is especially confusing when one clicks the small clear button embedded in= the combobox, because it clears the box, but the filtering is unchanged un= til the user goes to the keyboard to press enter. > = > = > This addresses bug 142900. > http://bugs.kde.org/show_bug.cgi?id=3D142900 > = > = > Diffs > ----- > = > kfile/kfilewidget.cpp 9b8cdeb = > = > Diff: http://git.reviewboard.kde.org/r/101013/diff > = > = > Testing > ------- > = > I've played around with it a fair bit and it seems to work fine. I've nev= er really worked with this code before, so if I'm doing something silly ple= ase let me know. > = > = > Thanks, > = > Parker > = > --===============4721733783361230175== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101013/ 

This revie=
w has been submitted with commit 6344c4f0505f7a0994bd7f36e5c607959d2dfbcf b=
y Parker Coates.

- Commit


On April 2nd, 2011, 11:47 p.m., Parker Coates wrote:

Review request for kdelibs.
By Parker Coates.

Updated April 2, 2011, 11:47 p.m.

Descripti= on 

This patch attempts to improve the usefulness and usability =
of KFileDialog's filter field when in Opening mode.

Firstly, if the filter text isn't: * the display name of one of the fil=
ters passed to the dialog or
                                   * one or more space separated mimetype s=
pecifiers (containing a '/')  or
                                   * one or more space separated file globs=
 (containing '*', '?' or "[.*]")
we convert the text to a glob by prepending and appending asterisks. This l=
ets the user enter a piece of text (without having to know any glob pattern=
s) and see only the files whose names contain that text, much the same as t=
hey would when filtering in Dolphin.

Secondly, the filtering updates on the fly as the filter text is typed. Pre=
viously, the filtering updated only when Return was pressed, which differs =
from the behaviour of most of KDE's other filter boxes. The old behavio=
ur is especially confusing when one clicks the small clear button embedded =
in the combobox, because it clears the box, but the filtering is unchanged =
until the user goes to the keyboard to press enter.

Testing <= /h1> 
I've played around with it a fair bit and it seems to wo=
rk fine. I've never really worked with this code before, so if I'm =
doing something silly please let me know.
Bugs: 142900

Diffs=

  • kfile/kfilewidget.cpp (9b8cdeb)

View Diff
--===============4721733783361230175==--