[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: Do not preserve username information on redirection
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2011-04-19 4:42:28
Message-ID: 20110419044228.1381.7950 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101153/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
This patch completely removes this automatic change performed at the job le=
vel. If an ioslave does not do the right thing, then it needs to be fixed. =
I really do not see the need for the job classes to do this automatically o=
n their own and override whatever the ioslave said was the redirection url!=
Can someone please shade a light as to why this was necessary when it was =
done ? I have not been able to decipher the reason behind it except to thin=
k that it was probably done as a cope out to hide issues in certain ioslave=
s.
However this has now come in full circle and it prevent proper functioning =
of the kio_ftp ioslave. How does this affect the ftp ioslave, please look a=
t a possible example with detailed analysis:
Instead of asking the user to cancel the password dialog just to correct a =
typo in the username component of the url they typed in, we want to accommo=
date them to change the username when prompted with the password dialog. We=
would then perform a redirection to update the application with the change=
d password. Doing so almost works except for the case where the user decide=
s to login anonymously from kio_ftp's password dialog. In that case, the us=
ername component in the redirect url will be set to blank which unfortunate=
ly gets overridden by the code this patch removes.
Diffs
-----
kio/kio/job.cpp 004b4c9 =
Diff: http://git.reviewboard.kde.org/r/101153/diff
Testing
-------
Thanks,
Dawit
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101153/">http://git.reviewboard.kde.org/r/101153/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch completely removes this automatic change performed at the job \
level. If an ioslave does not do the right thing, then it needs to be fixed. I really \
do not see the need for the job classes to do this automatically on their own and \
override whatever the ioslave said was the redirection url! Can someone please shade \
a light as to why this was necessary when it was done ? I have not been able to \
decipher the reason behind it except to think that it was probably done as a cope out \
to hide issues in certain ioslaves.
However this has now come in full circle and it prevent proper functioning of the \
kio_ftp ioslave. How does this affect the ftp ioslave, please look at a possible \
example with detailed analysis:
Instead of asking the user to cancel the password dialog just to correct a typo in \
the username component of the url they typed in, we want to accommodate them to \
change the username when prompted with the password dialog. We would then perform a \
redirection to update the application with the changed password. Doing so almost \
works except for the case where the user decides to login anonymously from \
kio_ftp's password dialog. In that case, the username component in the redirect \
url will be set to blank which unfortunately gets overridden by the code this patch \
removes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/job.cpp <span style="color: grey">(004b4c9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101153/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic