[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Do not preserve username information on
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2011-04-21 2:50:47
Message-ID: 20110421025047.22355.93949 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101153/
-----------------------------------------------------------
(Updated April 21, 2011, 2:50 a.m.)
Review request for kdelibs and David Faure.
Summary (updated)
-------
This patch completely removes the automatic restoration of the user name fr=
om the original url to the redirection url at the job level. Even though I =
tried to lookup why this was done a long time ago, I have not been able to =
decipher the reason behind it. I could only guess that it was probably done=
as a workaround for the deficiencies of some unknown ioslave that was not =
doing the right thing when constructing the redirection url.
Unfortunately this has now come in full circle to cause problems when attem=
pting to fix kio_ftp's login related bug reports. Namely I wanted to fix th=
e problem where the user typed a username as part of the ftp url and later =
on either changed it or choose to login anonymously when prompted with a pa=
ssword dialog. Right now the client never gets updated even when the user c=
hose to use a different username in the password dialog. IOW, the username =
reflected in the typed-in url is different from the one the user used to lo=
gin. You can guess what happens when the user then clicks on a folder or fi=
le after logging in.
The process I chose to use to update the client is to cause a redirection a=
nd that works fine so long as the redirection url contains a proper usernam=
e. Otherwise, the redirection handling slots in KIO::Job automatically re-i=
nsert the username from the old url into the new redirection url.
Diffs
-----
kio/kio/job.cpp 004b4c9 =
Diff: http://git.reviewboard.kde.org/r/101153/diff
Testing
-------
Thanks,
Dawit
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101153/">http://git.reviewboard.kde.org/r/101153/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated April 21, 2011, 2:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch completely removes the automatic restoration of the user name \
from the original url to the redirection url at the job level. Even though I tried to \
lookup why this was done a long time ago, I have not been able to decipher the reason \
behind it. I could only guess that it was probably done as a workaround for the \
deficiencies of some unknown ioslave that was not doing the right thing when \
constructing the redirection url.
Unfortunately this has now come in full circle to cause problems when attempting to \
fix kio_ftp's login related bug reports. Namely I wanted to fix the problem where \
the user typed a username as part of the ftp url and later on either changed it or \
choose to login anonymously when prompted with a password dialog. Right now the \
client never gets updated even when the user chose to use a different username in the \
password dialog. IOW, the username reflected in the typed-in url is different from \
the one the user used to login. You can guess what happens when the user then clicks \
on a folder or file after logging in.
The process I chose to use to update the client is to cause a redirection and that \
works fine so long as the redirection url contains a proper username. Otherwise, the \
redirection handling slots in KIO::Job automatically re-insert the username from the \
old url into the new redirection url.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/job.cpp <span style="color: grey">(004b4c9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101153/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic