From kde-core-devel Tue Apr 19 04:42:28 2011 From: "Dawit Alemayehu" Date: Tue, 19 Apr 2011 04:42:28 +0000 To: kde-core-devel Subject: Review Request: Do not preserve username information on redirection Message-Id: <20110419044228.1381.7950 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=130318818701421 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7981159737689281586==" --===============7981159737689281586== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101153/ ----------------------------------------------------------- Review request for kdelibs. Summary ------- This patch completely removes this automatic change performed at the job le= vel. If an ioslave does not do the right thing, then it needs to be fixed. = I really do not see the need for the job classes to do this automatically o= n their own and override whatever the ioslave said was the redirection url!= Can someone please shade a light as to why this was necessary when it was = done ? I have not been able to decipher the reason behind it except to thin= k that it was probably done as a cope out to hide issues in certain ioslave= s. However this has now come in full circle and it prevent proper functioning = of the kio_ftp ioslave. How does this affect the ftp ioslave, please look a= t a possible example with detailed analysis: Instead of asking the user to cancel the password dialog just to correct a = typo in the username component of the url they typed in, we want to accommo= date them to change the username when prompted with the password dialog. We= would then perform a redirection to update the application with the change= d password. Doing so almost works except for the case where the user decide= s to login anonymously from kio_ftp's password dialog. In that case, the us= ername component in the redirect url will be set to blank which unfortunate= ly gets overridden by the code this patch removes. Diffs ----- kio/kio/job.cpp 004b4c9 = Diff: http://git.reviewboard.kde.org/r/101153/diff Testing ------- Thanks, Dawit --===============7981159737689281586== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101153/

Review request for kdelibs.
By Dawit Alemayehu.

Descripti= on 

This patch completely removes this automatic change performe=
d at the job level. If an ioslave does not do the right thing, then it need=
s to be fixed. I really do not see the need for the job classes to do this =
automatically on their own and override whatever the ioslave said was the r=
edirection url! Can someone please shade a light as to why this was necessa=
ry when it was done ? I have not been able to decipher the reason behind it=
 except to think that it was probably done as a cope out to hide issues in =
certain ioslaves.

However this has now come in full circle and it prevent proper functioning =
of the kio_ftp ioslave. How does this affect the ftp ioslave, please look a=
t a possible example with detailed analysis:

Instead of asking the user to cancel the password dialog just to correct a =
typo in the username component of the url they typed in, we want to accommo=
date them to change the username when prompted with the password dialog. We=
 would then perform a redirection to update the application with the change=
d password. Doing so almost works except for the case where the user decide=
s to login anonymously from kio_ftp's password dialog. In that case, th=
e username component in the redirect url will be set to blank which unfortu=
nately gets overridden by the code this patch removes.

Diffs=

  • kio/kio/job.cpp (004b4c9)

View Diff
--===============7981159737689281586==--