[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/KDE/3.5/kdelibs/kioslave/http
From:       Thiago Macieira <thiago () kde ! org>
Date:       2005-12-30 3:52:12
Message-ID: 200512300152.24344.thiago () kde ! org
[Download RAW message or body]


Dawit Alemayehu wrote:
>Who added the "Proxy-Connection" request header ? There is no such
> header specified in RFC 2616. "Proxy-Connection" is strictly a response
> header! From the client persistency should always be specified through
> the "Connection: " header in HTTP/1.1 whether you are talking to a
> proxy or the target server.

NTLM requires it. Yes, it's broken, but it doesn't work without. See this 
message from Martijn yesterday morning:
http://lists.kde.org/?l=kfm-devel&m=113587597831864&w=2

What I don't understand is if NTLM requires the header or persistent 
connections. Or both.

355327     gyurco     if ( m_bPersistentProxyConnection )
355327     gyurco       header += "Proxy-Connection: Keep-Alive\r\n";

------------------------------------------------------------------------
r355327 | gyurco | 2004-10-17 13:48:14 -0300 (Dom, 17 Out 2004) | 10 lines

Fix http NTLM proxy authentication:
- Only try NTLM auth when persistent connection to proxy selected.
- Some missing checks for proxyAuthentication added.
- Send Proxy-Authorization: NTLM only in the initial handshaking, this 
prevents
sending NTLMSSP_NEGOTIATE header in every request.
- Send Proxy-Connection: Keep-Alive header if persistent connection to the
proxy server selected.
Tested with NTLM-enabled Squid-2.5. I feel that NTLM http authentication 
will
require some fix, too.

------------------------------------------------------------------------

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

5. Swa he géanhwearf tó timbran, and hwonne he cóm, lá! Unix cwæð "Hello, 
World". Ǽfre ǽghwilc wæs glæd and seo woruld wæs fréo.

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]