[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/KDE/3.5/kdelibs/kioslave/http
From:       Dawit Alemayehu <adawit () kde ! org>
Date:       2005-12-30 6:43:03
Message-ID: 200512300143.03075.adawit () kde ! org
[Download RAW message or body]

On Thursday 29 December 2005 22:52, Thiago Macieira wrote:
> Dawit Alemayehu wrote:
> >Who added the "Proxy-Connection" request header ? There is no such
> > header specified in RFC 2616. "Proxy-Connection" is strictly a response
> > header! From the client persistency should always be specified through
> > the "Connection: " header in HTTP/1.1 whether you are talking to a
> > proxy or the target server.
>
> NTLM requires it. Yes, it's broken, but it doesn't work without. See this
> message from Martijn yesterday morning:
> http://lists.kde.org/?l=kfm-devel&m=113587597831864&w=2
>
> What I don't understand is if NTLM requires the header or persistent
> connections. Or both.

That header is completely bogus unless it is an MS extension implemented by 
Squid which I seriously doubt. The problem is the code right above where you 
removed this one from... Unless persistent proxy connection is checked we 
send the "Connection: close" header is sent to all proxy servers which in 
turn forces them to close the connection after each request. Well if you use 
NTLM authentication this would obviously fail!  

The reason we started sending the "Connection:" header is a workaround for 
broken/old (HTTP/1.0) proxy servers such as Junkbuster. In HTTP/1.1 the 
connection is assumed to be persistent unless you explicitly send a 
"Connection: close" header. Anyways, this has to be fixed correctly and not 
simply by hacking stuff. I do not even know how/why the code below fixes this 
issue!!!

-- 
Regards,
Dawit A.
"Practice what you preach, preach what you practice"
[prev in list] [next in list] [prev in thread] [next in thread]