[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/KDE/3.5/kdelibs/kioslave/http
From:       Dawit Alemayehu <adawit () kde ! org>
Date:       2005-12-30 2:36:27
Message-ID: 200512292136.27635.adawit () kde ! org
[Download RAW message or body]

Who added the "Proxy-Connection" request header ? There is no such header 
specified in RFC 2616. "Proxy-Connection" is strictly a response header! From 
the client persistency should always be specified through the "Connection: " 
header in HTTP/1.1 whether you are talking to a proxy or the target server. 

On Thursday 29 December 2005 21:00, Thiago Macieira wrote:
> SVN commit 492490 by thiago:
>
> Only send the Proxy-Connection: header if we're talking to a proxy.
>
> BUG:119210
>
>
>  M  +5 -3      http.cc
>
>
> --- branches/KDE/3.5/kdelibs/kioslave/http/http.cc #492489:492490
> @@ -2378,9 +2378,6 @@
>      else
>        header += "Connection: close\r\n";
>
> -    if ( m_bPersistentProxyConnection )
> -      header += "Proxy-Connection: Keep-Alive\r\n";
> -
>      if (!m_request.userAgent.isEmpty())
>      {
>          header += "User-Agent: ";
> @@ -2539,7 +2536,12 @@
>
>      // Do we need to authorize to the proxy server ?
>      if ( m_state.doProxy && !m_bIsTunneled )
> +    {
> +      if ( m_bPersistentProxyConnection )
> +	header += "Proxy-Connection: Keep-Alive\r\n";
> +
>        header += proxyAuthenticationHeader();
> +    }
>
>      if ( m_protocol == "webdav" || m_protocol == "webdavs" )
>      {

-- 
Regards,
Dawit A.
"Practice what you preach, preach what you practice"
[prev in list] [next in list] [prev in thread] [next in thread]