From kde-commits Fri Dec 30 03:52:12 2005 From: Thiago Macieira Date: Fri, 30 Dec 2005 03:52:12 +0000 To: kde-commits Subject: Re: branches/KDE/3.5/kdelibs/kioslave/http Message-Id: <200512300152.24344.thiago () kde ! org> X-MARC-Message: https://marc.info/?l=kde-commits&m=113591476213537 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart1928968.uBlFfEa4ex" --nextPart1928968.uBlFfEa4ex Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Dawit Alemayehu wrote: >Who added the "Proxy-Connection" request header ? There is no such > header specified in RFC 2616. "Proxy-Connection" is strictly a response > header! From the client persistency should always be specified through > the "Connection: " header in HTTP/1.1 whether you are talking to a > proxy or the target server. NTLM requires it. Yes, it's broken, but it doesn't work without. See this=20 message from Martijn yesterday morning: http://lists.kde.org/?l=3Dkfm-devel&m=3D113587597831864&w=3D2 What I don't understand is if NTLM requires the header or persistent=20 connections. Or both. 355327 gyurco if ( m_bPersistentProxyConnection ) 355327 gyurco header +=3D "Proxy-Connection: Keep-Alive\r\n"; =2D----------------------------------------------------------------------- r355327 | gyurco | 2004-10-17 13:48:14 -0300 (Dom, 17 Out 2004) | 10 lines =46ix http NTLM proxy authentication: =2D Only try NTLM auth when persistent connection to proxy selected. =2D Some missing checks for proxyAuthentication added. =2D Send Proxy-Authorization: NTLM only in the initial handshaking, this=20 prevents sending NTLMSSP_NEGOTIATE header in every request. =2D Send Proxy-Connection: Keep-Alive header if persistent connection to the proxy server selected. Tested with NTLM-enabled Squid-2.5. I feel that NTLM http authentication=20 will require some fix, too. =2D----------------------------------------------------------------------- =2D-=20 Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org PGP/GPG: 0x6EF45358; fingerprint: E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358 5. Swa he g=C3=A9anhwearf t=C3=B3 timbran, and hwonne he c=C3=B3m, l=C3=A1!= Unix cw=C3=A6=C3=B0 "Hello,=20 World". =C7=BCfre =C7=BDghwilc w=C3=A6s gl=C3=A6d and seo woruld w=C3=A6s f= r=C3=A9o. --nextPart1928968.uBlFfEa4ex Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) iD8DBQBDtK73M/XwBW70U1gRApwPAJ92FytzrAmTIkR4sddrZmpibdC04QCgrtgJ jYZurxsMgi7eSZas6PR+pIQ= =wyN0 -----END PGP SIGNATURE----- --nextPart1928968.uBlFfEa4ex--