[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0
From: Stephen Kelly <steveire () gmail ! com>
Date: 2017-01-18 21:50:14
Message-ID: 20170118215014.31352.58179 () mimi ! kde ! org
[Download RAW message or body]
--===============7926637669965104422==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 16, 2017, 8:53 a.m., Kevin Funk wrote:
> > @Stephen: Let's re-introduce this patch? Laurent + me have applied \
> > `Q_DECL_OVERRIDE` everywhere. Do you want to double-check?
Sorry, I didn't get pinged by email about this, despite the mention from Albert \
below. Re-applying this sounds fine to me. Thanks for taking care of the porting!
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129724/#review102057
-----------------------------------------------------------
On Jan. 16, 2017, 9:12 a.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129724/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2017, 9:12 a.m.)
>
>
> Review request for Build System, KDE Frameworks and Stephen Kelly.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Gives a nice warning about something that should be marked as override but isn't
>
>
> Diffs
> -----
>
> kde-modules/KDEFrameworkCompilerSettings.cmake 038ddc3
>
> Diff: https://git.reviewboard.kde.org/r/129724/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Albert Astals Cid
>
>
--===============7926637669965104422==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129724/">https://git.reviewboard.kde.org/r/129724/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 16th, 2017, 8:53 a.m. UTC, <b>Kevin \
Funk</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">@Stephen: Let's re-introduce this patch? Laurent + me \
have applied <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">Q_DECL_OVERRIDE</code> \
everywhere. Do you want to double-check?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Sorry, I didn't get pinged by email about this, despite the mention from \
Albert below. Re-applying this sounds fine to me. Thanks for taking care of the \
porting!</p></pre> <br />
<p>- Stephen</p>
<br />
<p>On January 16th, 2017, 9:12 a.m. UTC, Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System, KDE Frameworks and Stephen Kelly.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated Jan. 16, 2017, 9:12 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Gives a nice warning about something that should be \
marked as override but isn't</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDEFrameworkCompilerSettings.cmake <span style="color: \
grey">(038ddc3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129724/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7926637669965104422==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic