[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    [Differential] [Commented On] D4188: Suppress warning message "No metadata file in the package..." w
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-01-18 21:53:48
Message-ID: 20170118215348.130080.91302.521D6896 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  A commented out warning doesn't make much sense.
  Either it's a valid warning at which point the root cause needs fixing not hiding, \
or it's wrong and should be removed.  
  The hard part of doing this change is working out which of those is correct.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D4188

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #frameworks, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4188" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>A commented out warning doesn&#039;t make \
much sense.<br /> Either it&#039;s a valid warning at which point the root cause \
needs fixing not hiding, or it&#039;s wrong and should be removed.</p>

<p>The hard part of doing this change is working out which of those is \
correct.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R290 \
KPackage</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4188" \
rel="noreferrer">https://phabricator.kde.org/D4188</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>marten, Frameworks, Plasma<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]