[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 129609: utils.js: Escape backslash in i18n string
From: Dominik Haumann <dhaumann () kde ! org>
Date: 2017-01-18 21:35:13
Message-ID: 20170118213513.31352.38444 () mimi ! kde ! org
[Download RAW message or body]
--===============3827649021206602654==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 4, 2016, 2:13 p.m., Dominik Haumann wrote:
> > I guess this is fine. Please commit.
@Alexander: Do you have commit access, or should we commit this for you?
- Dominik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129609/#review101268
-----------------------------------------------------------
On Dec. 3, 2016, 7:38 p.m., Alexander Potashev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129609/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2016, 7:38 p.m.)
>
>
> Review request for Kate and KDE Frameworks.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> utils.js: Escape backslash in i18n string
>
>
> Diffs
> -----
>
> src/script/data/commands/utils.js a47e2b41a3c2bb581c48b566244b108b531be71a
>
> Diff: https://git.reviewboard.kde.org/r/129609/diff/
>
>
> Testing
> -------
>
> None!
>
>
> Thanks,
>
> Alexander Potashev
>
>
--===============3827649021206602654==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129609/">https://git.reviewboard.kde.org/r/129609/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 4th, 2016, 2:13 p.m. UTC, <b>Dominik \
Haumann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I guess this is fine. Please commit.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">@Alexander: Do you have commit access, or should we commit this for \
you?</p></pre> <br />
<p>- Dominik</p>
<br />
<p>On December 3rd, 2016, 7:38 p.m. UTC, Alexander Potashev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate and KDE Frameworks.</div>
<div>By Alexander Potashev.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2016, 7:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">utils.js: Escape backslash in i18n string</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">None!</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/script/data/commands/utils.js <span style="color: \
grey">(a47e2b41a3c2bb581c48b566244b108b531be71a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129609/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3827649021206602654==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic