From kde-frameworks-devel Wed Jan 18 21:50:14 2017 From: Stephen Kelly Date: Wed, 18 Jan 2017 21:50:14 +0000 To: kde-frameworks-devel Subject: Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0 Message-Id: <20170118215014.31352.58179 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=148477622803825 --===============7926637669965104422== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 16, 2017, 8:53 a.m., Kevin Funk wrote: > > @Stephen: Let's re-introduce this patch? Laurent + me have applied `Q_DECL_OVERRIDE` everywhere. Do you want to double-check? Sorry, I didn't get pinged by email about this, despite the mention from Albert below. Re-applying this sounds fine to me. Thanks for taking care of the porting! - Stephen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/#review102057 ----------------------------------------------------------- On Jan. 16, 2017, 9:12 a.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129724/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2017, 9:12 a.m.) > > > Review request for Build System, KDE Frameworks and Stephen Kelly. > > > Repository: extra-cmake-modules > > > Description > ------- > > Gives a nice warning about something that should be marked as override but isn't > > > Diffs > ----- > > kde-modules/KDEFrameworkCompilerSettings.cmake 038ddc3 > > Diff: https://git.reviewboard.kde.org/r/129724/diff/ > > > Testing > ------- > > > Thanks, > > Albert Astals Cid > > --===============7926637669965104422== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/

On January 16th, 2017, 8:53 a.m. UTC, Kevin Funk wrote:

@Stephen: Let's re-introduce this patch? Laurent + me have applied Q_DECL_OVERRIDE everywhere. Do you want to double-check?

Sorry, I didn't get pinged by email about this, despite the mention from Albert below. Re-applying this sounds fine to me. Thanks for taking care of the porting!

- Stephen

On January 16th, 2017, 9:12 a.m. UTC, Albert Astals Cid wrote:

Review request for Build System, KDE Frameworks and Stephen Kelly.

By Albert Astals Cid.

Updated Jan. 16, 2017, 9:12 a.m.

Repository: extra-cmake-modules

Description

Gives a nice warning about something that should be marked as override but isn't

Diffs

kde-modules/KDEFrameworkCompilerSettings.cmake (038ddc3)

View Diff

--===============7926637669965104422==--