[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 120648: Encode the URIs which end up in DTD files
From: "Alex Merry" <alex.merry () kde ! org>
Date: 2014-10-21 21:08:27
Message-ID: 20141021210827.18179.42580 () probe ! kde ! org
[Download RAW message or body]
--===============2726462250028930966==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review68855
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Merry
On Oct. 20, 2014, 12:12 a.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120648/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 12:12 a.m.)
>
>
> Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and \
> kdewin.
>
> Repository: kdoctools
>
>
> Description
> -------
>
> The URI need to be encoded, because some valid characters for
> filenames are not valid according RFC 2396.
> Easy way to trigger the issue: when the path contains spaces,
> as it happens on MacOSX builds.
>
> See also https://git.reviewboard.kde.org/r/120649/ for the twin review on \
> kdelibs4support.
>
> Diffs
> -----
>
> cmake/uriencode.cmake PRE-CREATION
> src/CMakeLists.txt 341ecf4
>
> Diff: https://git.reviewboard.kde.org/r/120648/diff/
>
>
> Testing
> -------
>
> It compiles, but I can't properly test Mac and Windows scenarios
>
>
> Thanks,
>
> Luigi Toscano
>
>
--===============2726462250028930966==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120648/">https://git.reviewboard.kde.org/r/120648/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre> <br />
<p>- Alex Merry</p>
<br />
<p>On October 20th, 2014, 12:12 a.m. UTC, Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and \
kdewin.</div> <div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Oct. 20, 2014, 12:12 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The URI need to be encoded, because some valid \
characters for filenames are not valid according RFC 2396.
Easy way to trigger the issue: when the path contains spaces,
as it happens on MacOSX builds.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See also https://git.reviewboard.kde.org/r/120649/ for \
the twin review on kdelibs4support.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It compiles, but I can't properly test Mac and Windows \
scenarios</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/uriencode.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(341ecf4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120648/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2726462250028930966==--
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic