[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 120648: Encode the URIs which end up in DTD files
From: "Alex Merry" <alex.merry () kde ! org>
Date: 2014-10-21 21:02:27
Message-ID: 20141021210227.18179.89195 () probe ! kde ! org
[Download RAW message or body]
--===============8700457948145037083==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Oct. 19, 2014, 10:52 a.m., Alex Merry wrote:
> > src/CMakeLists.txt, line 19
> > <https://git.reviewboard.kde.org/r/120648/diff/1/?file=320540#file320540line19>
> >
> > You've already included it above...
>
> Luigi Toscano wrote:
> This is different, it's in a piece of code inside install(CODE...) which is \
> executed in a different moment (installation time). From my quick test it seems I \
> need the previous include is in a different scope.
Ah, you're absolutely right. Sorry.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review68696
-----------------------------------------------------------
On Oct. 20, 2014, 12:12 a.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120648/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 12:12 a.m.)
>
>
> Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and \
> kdewin.
>
> Repository: kdoctools
>
>
> Description
> -------
>
> The URI need to be encoded, because some valid characters for
> filenames are not valid according RFC 2396.
> Easy way to trigger the issue: when the path contains spaces,
> as it happens on MacOSX builds.
>
> See also https://git.reviewboard.kde.org/r/120649/ for the twin review on \
> kdelibs4support.
>
> Diffs
> -----
>
> cmake/uriencode.cmake PRE-CREATION
> src/CMakeLists.txt 341ecf4
>
> Diff: https://git.reviewboard.kde.org/r/120648/diff/
>
>
> Testing
> -------
>
> It compiles, but I can't properly test Mac and Windows scenarios
>
>
> Thanks,
>
> Luigi Toscano
>
>
--===============8700457948145037083==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120648/">https://git.reviewboard.kde.org/r/120648/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 19th, 2014, 10:52 a.m. UTC, <b>Alex \
Merry</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120648/diff/1/?file=320540#file320540line19" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">19</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">include(</span><span class="o">${</span><span \
class="nv">CMAKE_SOURCE_DIR</span><span class="o">}</span><span \
class="s">/cmake/uriencode.cmake</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">You've already included it above...</p></pre> </blockquote>
<p>On October 20th, 2014, 12:09 a.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
is different, it's in a piece of code inside install(CODE...) which is executed in a \
different moment (installation time). From my quick test it seems I need the previous \
include is in a different scope.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Ah, you're absolutely right. Sorry.</p></pre> <br />
<p>- Alex</p>
<br />
<p>On October 20th, 2014, 12:12 a.m. UTC, Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and \
kdewin.</div> <div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Oct. 20, 2014, 12:12 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The URI need to be encoded, because some valid \
characters for filenames are not valid according RFC 2396.
Easy way to trigger the issue: when the path contains spaces,
as it happens on MacOSX builds.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See also https://git.reviewboard.kde.org/r/120649/ for \
the twin review on kdelibs4support.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It compiles, but I can't properly test Mac and Windows \
scenarios</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/uriencode.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(341ecf4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120648/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8700457948145037083==--
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic