From kde-buildsystem Tue Oct 21 21:08:27 2014 From: "Alex Merry" Date: Tue, 21 Oct 2014 21:08:27 +0000 To: kde-buildsystem Subject: Re: Review Request 120648: Encode the URIs which end up in DTD files Message-Id: <20141021210827.18179.42580 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-buildsystem&m=141392575925570 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5939079565167704381==" --===============5939079565167704381== Content-Type: multipart/alternative; boundary="===============2726462250028930966==" --===============2726462250028930966== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68855 ----------------------------------------------------------- Ship it! Ship It! - Alex Merry On Oct. 20, 2014, 12:12 a.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120648/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 12:12 a.m.) > > > Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. > > > Repository: kdoctools > > > Description > ------- > > The URI need to be encoded, because some valid characters for > filenames are not valid according RFC 2396. > Easy way to trigger the issue: when the path contains spaces, > as it happens on MacOSX builds. > > See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. > > > Diffs > ----- > > cmake/uriencode.cmake PRE-CREATION > src/CMakeLists.txt 341ecf4 > > Diff: https://git.reviewboard.kde.org/r/120648/diff/ > > > Testing > ------- > > It compiles, but I can't properly test Mac and Windows scenarios > > > Thanks, > > Luigi Toscano > > --===============2726462250028930966== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/

Ship it!

Ship It!

- Alex Merry

On October 20th, 2014, 12:12 a.m. UTC, Luigi Toscano wrote:

Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin.

By Luigi Toscano.

Updated Oct. 20, 2014, 12:12 a.m.

Repository: kdoctools

Description

The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds.

See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support.

Testing

It compiles, but I can't properly test Mac and Windows scenarios

Diffs

cmake/uriencode.cmake (PRE-CREATION)
src/CMakeLists.txt (341ecf4)

View Diff

--===============2726462250028930966==-- --===============5939079565167704381== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem --===============5939079565167704381==--