--===============2942147958321150870== Content-Type: multipart/alternative; boundary="===============8700457948145037083==" --===============8700457948145037083== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 19, 2014, 10:52 a.m., Alex Merry wrote: > > src/CMakeLists.txt, line 19 > > > > > > You've already included it above... > > Luigi Toscano wrote: > This is different, it's in a piece of code inside install(CODE...) which is executed in a different moment (installation time). From my quick test it seems I need the previous include is in a different scope. Ah, you're absolutely right. Sorry. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68696 ----------------------------------------------------------- On Oct. 20, 2014, 12:12 a.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120648/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 12:12 a.m.) > > > Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin. > > > Repository: kdoctools > > > Description > ------- > > The URI need to be encoded, because some valid characters for > filenames are not valid according RFC 2396. > Easy way to trigger the issue: when the path contains spaces, > as it happens on MacOSX builds. > > See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support. > > > Diffs > ----- > > cmake/uriencode.cmake PRE-CREATION > src/CMakeLists.txt 341ecf4 > > Diff: https://git.reviewboard.kde.org/r/120648/diff/ > > > Testing > ------- > > It compiles, but I can't properly test Mac and Windows scenarios > > > Thanks, > > Luigi Toscano > > --===============8700457948145037083== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/

On October 19th, 2014, 10:52 a.m. UTC, Alex Merry wrote:
src/CMakeLists.txt (Diff revision 1)
19
        include(${CMAKE_SOURCE_DIR}/cmake/uriencode.cmake)
You've already included it above...
On October 20th, 2014, 12:09 a.m. UTC, Luigi Toscano wrote:
This is different, it's in a piece of code inside install(CODE...) which is executed in a different moment (installation time). From my quick test it seems I need the previous include is in a different scope.

Ah, you're absolutely right. Sorry.

- Alex

On October 20th, 2014, 12:12 a.m. UTC, Luigi Toscano wrote:

Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin.

By Luigi Toscano.

Updated Oct. 20, 2014, 12:12 a.m.

Repository: kdoctools

Description

The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds.

See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support.

Testing

It compiles, but I can't properly test Mac and Windows scenarios

Diffs

cmake/uriencode.cmake (PRE-CREATION)
src/CMakeLists.txt (341ecf4)

--===============8700457948145037083==-- --===============2942147958321150870== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem --===============2942147958321150870==--