'Re: Review Request 120655: If find_dependency() fails, so should the Config file it is in'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: Review Request 120655: If find_dependency() fails, so should the Config file it is in
From:       "Alex Merry" <alex.merry () kde ! org>
Date:       2014-10-21 21:00:42
Message-ID: 20141021210042.18178.77451 () probe ! kde ! org
[Download RAW message or body]

--===============3825914386404489662==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120655/
-----------------------------------------------------------

(Updated Oct. 21, 2014, 9 p.m.)

Status
------

This change has been marked as submitted.

Review request for Extra Cmake Modules and Harald Sitter.

Repository: extra-cmake-modules

Description
-------

If find_dependency() fails, so should the Config file it is in

This matches the behaviour of CMake's version of this macro, which we defer to in \
CMake 3.0 and later.

Diffs
-----

  modules/ECMPackageConfigHelpers.cmake da65c3eac39edb0b00a2172af7b58f310d967722 

Diff: https://git.reviewboard.kde.org/r/120655/diff/

Testing
-------

Ran `make test`. Built everything KF5-related using CMake 2.8.12 and ECM with this \
change. Haven't got round to trying to remove a dep and running CMake.

Thanks,

Alex Merry

--===============3825914386404489662==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120655/">https://git.reviewboard.kde.org/r/120655/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Extra Cmake Modules and Harald Sitter.</div>
<div>By Alex Merry.</div>

<p style="color: grey;"><i>Updated Oct. 21, 2014, 9 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If find_dependency() fails, so should the Config file \
it is in</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This matches the behaviour of CMake's version of this \
macro, which we defer to in CMake 3.0 and later.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">make \
test</code>. Built everything KF5-related using CMake 2.8.12 and ECM with this \
change. Haven't got round to trying to remove a dep and running CMake.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>modules/ECMPackageConfigHelpers.cmake <span style="color: \
grey">(da65c3eac39edb0b00a2172af7b58f310d967722)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120655/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3825914386404489662==--

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

[prev in list] [next in list] [prev in thread] [next in thread] 