'Review Request 120481: Do not skip searching for X11 and Wayland modules on Windows'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Review Request 120481: Do not skip searching for X11 and Wayland modules on Windows
From:       "Alex Merry" <alex.merry () kde ! org>
Date:       2014-10-03 16:19:02
Message-ID: 20141003161902.15676.43759 () probe ! kde ! org
[Download RAW message or body]

--===============7474130392191691784==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120481/
-----------------------------------------------------------

Review request for Extra Cmake Modules and Martin Gräßlin.

Repository: extra-cmake-modules

Description
-------

While the search is unlikely to succeed on Windows, having different
behaviour between the platforms (eg: find_package(Wayland REQUIRED) was
not fatal on Windows, even though Wayland_FOUND would always be FALSE)
is not ideal, and if someone did port them to Windows for some reason,
the find modules should support that.

If applications actually want different behaviour between platforms
(like requiring a module on Unix, but not on Windows), they should
implement that logic themselves (since they will have to deal with
targets not being defined, etc, anyway).

Diffs
-----

  find-modules/FindEGL.cmake f1962b9abc7fef381efe073c1ce18379ab2a47da 
  find-modules/FindWayland.cmake 11716f04444497db380e94b3d8ef69f41546f789 
  find-modules/FindX11_XCB.cmake 05d18d5adfd197fea4f0c7defbe53da776ebac79 
  find-modules/FindXCB.cmake 76d69fd790fb4831abd8a8351a684b97f6816081 

Diff: https://git.reviewboard.kde.org/r/120481/diff/

Testing
-------

None whatsoever, since I want Martin's feedback on the idea first.

Thanks,

Alex Merry

--===============7474130392191691784==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120481/">https://git.reviewboard.kde.org/r/120481/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Extra Cmake Modules and Martin Gräßlin.</div>
<div>By Alex Merry.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">While the search is unlikely to succeed on Windows, \
having different<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> behaviour between the platforms (eg: \
find_package(Wayland REQUIRED) was<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> not fatal on Windows, \
even though Wayland_FOUND would always be FALSE)<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> is not ideal, and if \
someone did port them to Windows for some reason,<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> the \
find modules should support that.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">If applications \
actually want different behaviour between platforms<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
(like requiring a module on Unix, but not on Windows), they should<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
implement that logic themselves (since they will have to deal with<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
targets not being defined, etc, anyway).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">None whatsoever, since I want Martin's feedback on the \
idea first.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>find-modules/FindEGL.cmake <span style="color: \
grey">(f1962b9abc7fef381efe073c1ce18379ab2a47da)</span></li>

 <li>find-modules/FindWayland.cmake <span style="color: \
grey">(11716f04444497db380e94b3d8ef69f41546f789)</span></li>

 <li>find-modules/FindX11_XCB.cmake <span style="color: \
grey">(05d18d5adfd197fea4f0c7defbe53da776ebac79)</span></li>

 <li>find-modules/FindXCB.cmake <span style="color: \
grey">(76d69fd790fb4831abd8a8351a684b97f6816081)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120481/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7474130392191691784==--

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

[prev in list] [next in list] [prev in thread] [next in thread] 