--===============7725686353744458705== Content-Type: multipart/alternative; boundary="===============7474130392191691784==" --===============7474130392191691784== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120481/ ----------------------------------------------------------- Review request for Extra Cmake Modules and Martin Gräßlin. Repository: extra-cmake-modules Description ------- While the search is unlikely to succeed on Windows, having different behaviour between the platforms (eg: find_package(Wayland REQUIRED) was not fatal on Windows, even though Wayland_FOUND would always be FALSE) is not ideal, and if someone did port them to Windows for some reason, the find modules should support that. If applications actually want different behaviour between platforms (like requiring a module on Unix, but not on Windows), they should implement that logic themselves (since they will have to deal with targets not being defined, etc, anyway). Diffs ----- find-modules/FindEGL.cmake f1962b9abc7fef381efe073c1ce18379ab2a47da find-modules/FindWayland.cmake 11716f04444497db380e94b3d8ef69f41546f789 find-modules/FindX11_XCB.cmake 05d18d5adfd197fea4f0c7defbe53da776ebac79 find-modules/FindXCB.cmake 76d69fd790fb4831abd8a8351a684b97f6816081 Diff: https://git.reviewboard.kde.org/r/120481/diff/ Testing ------- None whatsoever, since I want Martin's feedback on the idea first. Thanks, Alex Merry --===============7474130392191691784== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120481/

Review request for Extra Cmake Modules and Martin Gräßlin.
By Alex Merry.
Repository: extra-cmake-modules

Description 

While the search is unlikely to succeed on Windows, having different

behaviour between the platforms (eg: find_package(Wayland REQUIRED) was

not fatal on Windows, even though Wayland_FOUND would always be FALSE)

is not ideal, and if someone did port them to Windows for some reason,

the find modules should support that.


If applications actually want different behaviour between platforms

(like requiring a module on Unix, but not on Windows), they should

implement that logic themselves (since they will have to deal with

targets not being defined, etc, anyway).

Testing 

None whatsoever, since I want Martin's feedback on the idea first.

Diffs

  • find-modules/FindEGL.cmake (f1962b9abc7fef381efe073c1ce18379ab2a47da)
  • find-modules/FindWayland.cmake (11716f04444497db380e94b3d8ef69f41546f789)
  • find-modules/FindX11_XCB.cmake (05d18d5adfd197fea4f0c7defbe53da776ebac79)
  • find-modules/FindXCB.cmake (76d69fd790fb4831abd8a8351a684b97f6816081)

View Diff
--===============7474130392191691784==-- --===============7725686353744458705== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem --===============7725686353744458705==--